Lucas Berger
b156fe48cf
Tasks completed: 5/5 - Fix text update race condition (remove parallel message) - Fix batch update data chain (Build Progress Message reference) - Fix batch action data chain (Build Progress Message reference) - Add fuzzy matching to logs and fix chatId reference - Add timestamp to logs refresh for message not modified error SUMMARY: .planning/phases/10-workflow-modularization/10-07-SUMMARY.md
98 lines
3.8 KiB
Markdown
98 lines
3.8 KiB
Markdown
# Project State — Unraid Docker Manager
|
|
|
|
## Current Position
|
|
|
|
- **Milestone:** v1.2 — Modularization & Polish
|
|
- **Phase:** 10 of 13 (Workflow Modularization) — COMPLETE + UAT GAP CLOSURE
|
|
- **Status:** Ready for Phase 10.1
|
|
- **Last activity:** 2026-02-04 — Completed 10-07 (UAT gap closure)
|
|
|
|
## Progress
|
|
|
|
```
|
|
v1.0: [██████████] 100% SHIPPED
|
|
v1.1: [██████████] 100% SHIPPED
|
|
|
|
v1.2: [███░░░░░░░] 25%
|
|
|
|
Phase 10: Workflow Modularization [██████████] 100% COMPLETE (+ 10-07 UAT fixes)
|
|
Phase 10.1: Aggressive Modularization [ ] Pending (INSERTED)
|
|
Phase 10.2: Better Logging & Log Management [ ] Pending (INSERTED)
|
|
Phase 11: Update All & Callback Limits [ ] Pending
|
|
Phase 12: Polish & Audit [ ] Pending
|
|
Phase 13: Documentation Overhaul [ ] Pending
|
|
```
|
|
|
|
## Phase 10 Completion Summary
|
|
|
|
| Plan | Description | Status |
|
|
|------|-------------|--------|
|
|
| 10-01 | Orphan node cleanup | Complete |
|
|
| 10-02 | Container Update sub-workflow | Complete |
|
|
| 10-03 | Container Actions sub-workflow | Complete |
|
|
| 10-04 | Integration verification | Complete |
|
|
| 10-05 | Complete modularization (batch, logs) | Complete |
|
|
| 10-06 | Remediation: routing, logs, cleanup | Complete |
|
|
| 10-07 | UAT gap closure (5 fixes) | Complete |
|
|
|
|
**Achievements:**
|
|
- 3 sub-workflows created and deployed (Update, Actions, Logs)
|
|
- All container operations consolidated (no duplicate logic)
|
|
- Old inline batch execution path removed
|
|
- Legacy callbacks modernized to new format
|
|
- Main workflow: 209 -> 192 nodes (-8%)
|
|
- 6 Python helper scripts removed
|
|
- UAT gaps closed: race condition, data chain errors, fuzzy matching, refresh errors
|
|
|
|
## Key Artifacts
|
|
|
|
- `n8n-workflow.json` — Main workflow (192 nodes)
|
|
- `n8n-container-update.json` — ID: `7AvTzLtKXM2hZTio92_mC`
|
|
- `n8n-container-actions.json` — ID: `fYSZS5PkH0VSEaT5`
|
|
- `n8n-container-logs.json` — ID: `oE7aO2GhbksXDEIw`
|
|
|
|
## Technical Notes
|
|
|
|
**n8n typeVersion 1.2 requirement:**
|
|
```json
|
|
"workflowId": { "__rl": true, "mode": "list", "value": "<id>" }
|
|
```
|
|
|
|
**Docker API success detection:**
|
|
- 204 No Content = success (empty response body)
|
|
- Check `!response.message && !response.error`
|
|
|
|
**Sub-workflow input contracts:**
|
|
- Container Update: containerId, containerName, chatId, messageId, responseMode
|
|
- Container Actions: containerId, containerName, action, chatId, messageId, responseMode
|
|
- Container Logs: containerId/containerName, lineCount, chatId, messageId, responseMode
|
|
|
|
**Data chain pattern (10-07):**
|
|
- Use `$('Build Progress Message').item.json` to reference data across async nodes
|
|
- Do not rely on `$json` after Telegram API calls (response overwrites data)
|
|
|
|
## Accumulated Decisions
|
|
|
|
| Phase | Decision | Rationale |
|
|
|-------|----------|-----------|
|
|
| 10-05 | Use placeholder workflow ID for logs sub-workflow | ID assigned by n8n on import |
|
|
| 10-05 | Retain Parse Logs Command in main workflow | Handles error cases before sub-workflow call |
|
|
| 10-06 | Remove old batch inline path | Migrated to bexec: callback format, uses sub-workflow |
|
|
| 10-06 | Defer aggressive modularization to 10.1 | Core goals achieved, deeper work needs separate phase |
|
|
| 10-07 | Timestamp on logs refresh | Prevents "message not modified" error, shows freshness |
|
|
| 10-07 | Fuzzy matching in logs sub-workflow | Simpler than duplicating Docker query infrastructure |
|
|
|
|
## Next Step
|
|
|
|
**Phase 10.1: Aggressive Workflow Modularization**
|
|
|
|
Goal: Decompose main workflow to ~50-80 nodes with domain sub-workflows:
|
|
- UX/Keyboard sub-workflow (batch selection UI, pagination)
|
|
- Container Status sub-workflow (list, status display)
|
|
- Confirmation sub-workflow (all confirmation dialogs)
|
|
|
|
Run `/gsd:plan-phase 10.1` to create execution plans.
|
|
|
|
---
|
|
*Auto-maintained by GSD workflow*
|