Lucas Berger
124 lines
4.6 KiB
Markdown
124 lines
4.6 KiB
Markdown
---
|
|
phase: 10.1-aggressive-workflow-modularization
|
|
plan: 09
|
|
subsystem: workflow
|
|
tags: [n8n, workflow, data-flow, bug-fix, UAT]
|
|
|
|
# Dependency graph
|
|
requires:
|
|
- phase: 10.1-08
|
|
provides: UAT diagnosis with root causes for 4 issues
|
|
provides:
|
|
- Three UAT gap closures: disambiguation keyboard, confirmation cancel, /list command
|
|
- Corrected data flow in Build Batch Keyboard (actionType field)
|
|
- Dynamic input reference in Build Cancel Return Submenu
|
|
- List command routing in Keyword Router
|
|
affects: [10.1-UAT-retest]
|
|
|
|
# Tech tracking
|
|
tech-stack:
|
|
added: []
|
|
patterns:
|
|
- "Dynamic input reference ($input.item.json) for nodes with multiple predecessors"
|
|
- "Action field vs actionType field distinction in matching sub-workflow returns"
|
|
|
|
key-files:
|
|
created: []
|
|
modified: [n8n-workflow.json]
|
|
|
|
key-decisions:
|
|
- "Added /list as alias routing to same output as /status command"
|
|
- "Used $input.item.json for dynamic predecessor reference in cancel return path"
|
|
|
|
patterns-established:
|
|
- "$input.item.json pattern: Use for nodes with multiple incoming paths instead of hardcoded node references"
|
|
- "Action type distinction: Sub-workflow returns both 'action' (routing label) and 'actionType' (user's requested action)"
|
|
|
|
# Metrics
|
|
duration: 3min
|
|
completed: 2026-02-08
|
|
---
|
|
|
|
# Phase 10.1 Plan 09: UAT Gap Closure - Data Flow Fixes
|
|
|
|
**Fixed three data flow bugs: disambiguation keyboard action field, confirmation cancel predecessor reference, and missing /list command route**
|
|
|
|
## Performance
|
|
|
|
- **Duration:** 3 minutes
|
|
- **Started:** 2026-02-08T14:53:13Z
|
|
- **Completed:** 2026-02-08T14:56:53Z
|
|
- **Tasks:** 4
|
|
- **Files modified:** 1
|
|
|
|
## Accomplishments
|
|
- Fixed Build Batch Keyboard to read actionType field instead of action, enabling correct disambiguation keyboard text and callbacks
|
|
- Fixed Build Cancel Return Submenu to use dynamic $input reference, allowing confirmation dialog cancel to return to container status
|
|
- Added /list command to Keyword Router as alias for status command
|
|
- Deployed all fixes to production n8n instance
|
|
|
|
## Task Commits
|
|
|
|
Each task was committed atomically:
|
|
|
|
1. **Task 1: Fix Build Batch Keyboard to use actionType field** - `27326b8` (fix)
|
|
- Changed `const action = $json.action` to `$json.actionType`
|
|
- Fixes UAT issue: disambiguation keyboard showing "multiple all?" instead of actual action
|
|
|
|
2. **Task 2: Fix Build Cancel Return Submenu to use dynamic input** - `bbb9694` (fix)
|
|
- Changed `$('Prepare Cancel Return').item.json` to `$input.item.json`
|
|
- Fixes UAT issue: cancel from confirmation dialog not returning to container status view
|
|
|
|
3. **Task 3: Add /list command to Keyword Router** - `9e4bfb1` (feat)
|
|
- Added "list" route with same outputKey as "status" route
|
|
- Fixes UAT issue: /list command showing help text instead of container list
|
|
|
|
4. **Task 4: Deploy updated main workflow via n8n API** - `80555a7` (chore)
|
|
- Deployed n8n-workflow.json to production instance (ID: HmiXBlJefBRPMS0m4iNYc)
|
|
|
|
## Files Created/Modified
|
|
- `n8n-workflow.json` - Main workflow with three bug fixes applied
|
|
|
|
## Decisions Made
|
|
|
|
**1. List command implementation: Alias approach**
|
|
- Added "list" as route in Keyword Router with same output as "status"
|
|
- Rationale: Status command already provides container list functionality; creating an alias is simpler than duplicating logic
|
|
|
|
**2. Dynamic predecessor reference pattern**
|
|
- Used `$input.item.json` instead of hardcoded node name
|
|
- Rationale: Build Cancel Return Submenu has two incoming paths; dynamic reference works for both
|
|
|
|
## Deviations from Plan
|
|
|
|
None - plan executed exactly as written.
|
|
|
|
## Issues Encountered
|
|
|
|
**API deployment field restrictions**
|
|
- **Issue:** Initial deployment attempts failed with 400 errors for read-only fields
|
|
- **Resolution:** Removed `active` and `tags` fields from deployment payload, keeping only `name`, `nodes`, `connections`, `settings`, `staticData`
|
|
- **Outcome:** Successful deployment with HTTP 200
|
|
|
|
## Next Phase Readiness
|
|
|
|
Three UAT gaps closed. Ready for UAT re-test to verify fixes:
|
|
1. Disambiguation keyboard should show "stop/start/restart" not "multiple"
|
|
2. Cancel from confirmation dialog should return to container status view
|
|
3. /list command should show paginated container list
|
|
|
|
No blockers for UAT re-test.
|
|
|
|
---
|
|
*Phase: 10.1-aggressive-workflow-modularization*
|
|
*Completed: 2026-02-08*
|
|
|
|
## Self-Check: PASSED
|
|
|
|
All claims verified:
|
|
- ✓ n8n-workflow.json exists and was modified
|
|
- ✓ Commit 27326b8 exists (Task 1: Build Batch Keyboard fix)
|
|
- ✓ Commit bbb9694 exists (Task 2: Build Cancel Return Submenu fix)
|
|
- ✓ Commit 9e4bfb1 exists (Task 3: Keyword Router /list command)
|
|
- ✓ Commit 80555a7 exists (Task 4: n8n deployment)
|