luckberg/familysync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: remove unused Redis service and references #26

Merged
luckberg merged 3 commits from gsd/quick-260618-smr-remove-redis into main 2026-06-18 21:06:34 -04:00
Conversation 0 Commits 3 Files Changed 15
+173 -38
luckberg commented 2026-06-18 20:53:17 -04:00
Owner
Copy Link
Copy Source

Summary

Remove the unused Redis service and all references. Redis was confirmed dead weight at runtime:

  • No ioredis/redis client import anywhere in apps/
  • No REDIS_* environment variables read in code
  • ioredis is not a dependency in any package.json

It existed only as a compose service plus documentation/e2e-config references that implied it was part of the stack or "reserved for future pub/sub".

Changes

  • Compose: removed the redis service from docker-compose.yml and the redis ports override from docker-compose.dev.yml. The api depends_on only referenced mariadb, so it was untouched.
  • Docs/config: removed every Redis reference from CLAUDE.md (constraints line, ioredis stack-table row, "Redis present in stack" sentence, compose-tree comment), README.md, docs/ARCHITECTURE.md, docs/CONFIGURATION.md, docs/deployment.md, docs/DEVELOPMENT.md, docs/GETTING-STARTED.md, docs/TESTING.md, apps/pwa/e2e/README.md, and apps/pwa/playwright.config.ts.

Deliberately kept

The in-memory-vs-Redis design-rationale comments (decisions D-12/D-18) in listEmitter.ts, reminderScheduler.ts, linkNonceStore.ts, and localAuth.ts — these document why in-memory is used instead of Redis and remain valuable.

Verification

  • grep -rniE redis across compose + docs + e2e returns only the 4 kept rationale comments
  • docker compose -f docker-compose.yml -f docker-compose.dev.yml config parses clean (0 redis in rendered config)
  • pnpm format:check green

🤖 Generated with Claude Code

## Summary Remove the **unused Redis service and all references**. Redis was confirmed dead weight at runtime: - No `ioredis`/redis client import anywhere in `apps/` - No `REDIS_*` environment variables read in code - `ioredis` is not a dependency in any `package.json` It existed only as a compose service plus documentation/e2e-config references that implied it was part of the stack or "reserved for future pub/sub". ## Changes - **Compose:** removed the `redis` service from `docker-compose.yml` and the `redis` ports override from `docker-compose.dev.yml`. The api `depends_on` only referenced `mariadb`, so it was untouched. - **Docs/config:** removed every Redis reference from `CLAUDE.md` (constraints line, `ioredis` stack-table row, "Redis present in stack" sentence, compose-tree comment), `README.md`, `docs/ARCHITECTURE.md`, `docs/CONFIGURATION.md`, `docs/deployment.md`, `docs/DEVELOPMENT.md`, `docs/GETTING-STARTED.md`, `docs/TESTING.md`, `apps/pwa/e2e/README.md`, and `apps/pwa/playwright.config.ts`. ## Deliberately kept The in-memory-vs-Redis **design-rationale** comments (decisions D-12/D-18) in `listEmitter.ts`, `reminderScheduler.ts`, `linkNonceStore.ts`, and `localAuth.ts` — these document *why* in-memory is used instead of Redis and remain valuable. ## Verification - [x] `grep -rniE redis` across compose + docs + e2e returns only the 4 kept rationale comments - [x] `docker compose -f docker-compose.yml -f docker-compose.dev.yml config` parses clean (0 redis in rendered config) - [x] `pnpm format:check` green 🤖 Generated with [Claude Code](https://claude.com/claude-code)
luckberg added 3 commits 2026-06-18 20:53:18 -04:00
chore(260618-smr): remove redis service from compose files b968f5d53b 
- docker-compose.yml: delete redis service block (redis:7-alpine)
- docker-compose.dev.yml: delete redis ports override block (6379:6379)
docs(260618-smr): remove Redis references from documentation and e2e config 0b4266628b 
- CLAUDE.md: remove Redis constraint, ioredis library row, Redis architecture sentence, update compose comment
- README.md: remove Redis from prereqs, quick-start command, compose description, tech-stack live-sync row
- docs/ARCHITECTURE.md: delete Redis infrastructure table row
- docs/CONFIGURATION.md: remove Redis localhost:6379 mention from dev section
- docs/deployment.md: delete redis services table row
- docs/DEVELOPMENT.md: remove prereq mention, heading, two up commands, expose bullet, stack comment
- docs/GETTING-STARTED.md: prereq row, up command, prose mention
- docs/TESTING.md: 'API and MariaDB' (was API, MariaDB, and Redis)
- apps/pwa/e2e/README.md: delete Redis on :6379 bullet
- apps/pwa/playwright.config.ts: two comments updated (API+MariaDB, not API+MariaDB+Redis)
docs(quick-260618-smr): remove unused Redis service and references
CI / changes (pull_request) Successful in 4s
Details
CI / api (pull_request) Successful in 2m3s
Details
CI / fast-checks (pull_request) Successful in 2m28s
Details
CI / security (pull_request) Successful in 57s
Details
CI / harness (pull_request) Successful in 5m25s
Details
CI / gate (pull_request) Successful in 3s
Details
96bb3144ec
luckberg merged commit 2276a254e4 into main 2026-06-18 21:06:34 -04:00
luckberg deleted branch gsd/quick-260618-smr-remove-redis 2026-06-18 21:06:35 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
luckberg
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: luckberg/familysync#26