luckberg/familysync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Isolate local API tests to a dedicated familysync_test DB (quick 260613-ndv) #18

Merged
luckberg merged 5 commits from quick/260613-ndv-test-db-isolation into main 2026-06-13 20:32:45 -04:00
Conversation 0 Commits 5 Files Changed 7
+456 -11
5 Commits
Author SHA1 Message Date
Lucas Berger 4517432dca style(quick-260613-ndv): prettier-format global-setup.ts
CI / changes (pull_request) Successful in 2s
Details
CI / fast-checks (pull_request) Successful in 1m24s
Details
CI / api (pull_request) Successful in 1m3s
Details
CI / harness (pull_request) Successful in 4m9s
Details
CI / security (pull_request) Successful in 39s
Details
CI / gate (pull_request) Successful in 1s
Details
2026-06-13 17:15:45 -04:00
Lucas Berger e687cb96e7 docs(quick-260613-ndv): plan + summary + state for test-DB isolation 2026-06-13 17:15:45 -04:00
Lucas Berger 24cb7569bf fix(quick-260613-ndv): reset familysync_test each run (truncate-all) 
CREATE DATABASE IF NOT EXISTS reuses the prior run's data, so the test DB
would itself accumulate users run-over-run (the same flaky list_shares
fan-out the dev DB suffered). Truncate every table (except the drizzle
migration ledger) at globalSetup start, FK-safe, so each run is a clean
deterministic slate. Verified: familysync_test users 186 -> 93 across a run
(reset, not doubled); dev familysync untouched at 3.
 2026-06-13 17:14:51 -04:00
Lucas Berger f39bd308b2 chore(quick-260613-ndv-02): clean-slate comment in setup.ts + README local-test docs 
- Update apps/api/test/setup.ts header: clarify tests run against familysync_test
  (provisioned by global-setup.ts), document users-cleanup decision (intact across
  tests), and note CI-vs-local env difference
- Add apps/api/README.md "Running API tests locally" section: documents the test
  DB isolation, run command, DB_ROOT_PASSWORD requirement, and CI no-op behaviour
- Fix apps/api/test/global-setup.ts: switch from drizzle({ client, mode }) to
  drizzle(pool, { mode }) — drizzle-orm@0.45.2 isConfig() has a tautological OR
  in the `mode` branch that always returns false, causing the combined-config form
  to pass the config object as the client (client.query is not a function); two-arg
  form routes correctly; 244/244 tests pass against familysync_test
 2026-06-13 17:14:51 -04:00
Lucas Berger 1eda6678bc chore(quick-260613-ndv-01): add globalSetup for familysync_test isolation 
- Create apps/api/test/global-setup.ts: root-provisions + grants + migrates
  familysync_test (local only); no-op when process.env.CI is truthy (T-ndv-04)
- Update apps/api/vitest.config.ts: wire globalSetup; add CI-gated test.env
  override (DB_NAME=familysync_test, DB_HOST) so workers never touch dev DB
 2026-06-13 17:14:51 -04:00