docs(20): mark IN-04 resolved — review fully clean
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
5161bd39c2
commit
8829fd22b5
@@ -52,8 +52,8 @@ independently confirmed 0 critical / 0 warning remain.
|
|||||||
|
|
||||||
## Introduced during fixes (caught by iteration-2 re-review)
|
## Introduced during fixes (caught by iteration-2 re-review)
|
||||||
|
|
||||||
- **IN-04 (Info, open):** The no-op profile-save path (`mutationFn` returns early on an
|
- **IN-04 (Info, resolved):** The no-op profile-save path (`mutationFn` returns early on an
|
||||||
empty payload) still triggers `onSuccess`, so the "Profile saved." toast fires and the
|
empty payload) triggered `onSuccess`, firing the "Profile saved." toast and refetching the
|
||||||
`['admin','members']` query refetches even when nothing changed. Cosmetic. Fix: skip the
|
`['admin','members']` query even when nothing changed. Fixed in `5161bd3` — `mutationFn`
|
||||||
toast/refetch when the computed payload is empty. Not auto-applied — re-review returned
|
now returns a `changed` flag and `onSuccess` skips the toast/refetch when no write occurred.
|
||||||
`status: clean` (no critical/warning), so the `--auto` loop exited before a third pass.
|
Typecheck/eslint/prettier all pass.
|
||||||
|
|||||||
@@ -12,8 +12,8 @@ files_reviewed_list:
|
|||||||
findings:
|
findings:
|
||||||
critical: 0
|
critical: 0
|
||||||
warning: 0
|
warning: 0
|
||||||
info: 1
|
info: 0
|
||||||
total: 1
|
total: 0
|
||||||
status: clean
|
status: clean
|
||||||
---
|
---
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user