From 8829fd22b5561f8cf085e83cdf14b06021aa546e Mon Sep 17 00:00:00 2001 From: Lucas Berger Date: Thu, 18 Jun 2026 18:22:43 -0400 Subject: [PATCH] =?UTF-8?q?docs(20):=20mark=20IN-04=20resolved=20=E2=80=94?= =?UTF-8?q?=20review=20fully=20clean?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Opus 4.8 (1M context) --- .../20-REVIEW-FIX.md | 10 +++++----- .../20-admin-member-editor-form-declutter/20-REVIEW.md | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.planning/phases/20-admin-member-editor-form-declutter/20-REVIEW-FIX.md b/.planning/phases/20-admin-member-editor-form-declutter/20-REVIEW-FIX.md index 7568689..51f33b2 100644 --- a/.planning/phases/20-admin-member-editor-form-declutter/20-REVIEW-FIX.md +++ b/.planning/phases/20-admin-member-editor-form-declutter/20-REVIEW-FIX.md @@ -52,8 +52,8 @@ independently confirmed 0 critical / 0 warning remain. ## Introduced during fixes (caught by iteration-2 re-review) -- **IN-04 (Info, open):** The no-op profile-save path (`mutationFn` returns early on an - empty payload) still triggers `onSuccess`, so the "Profile saved." toast fires and the - `['admin','members']` query refetches even when nothing changed. Cosmetic. Fix: skip the - toast/refetch when the computed payload is empty. Not auto-applied — re-review returned - `status: clean` (no critical/warning), so the `--auto` loop exited before a third pass. +- **IN-04 (Info, resolved):** The no-op profile-save path (`mutationFn` returns early on an + empty payload) triggered `onSuccess`, firing the "Profile saved." toast and refetching the + `['admin','members']` query even when nothing changed. Fixed in `5161bd3` — `mutationFn` + now returns a `changed` flag and `onSuccess` skips the toast/refetch when no write occurred. + Typecheck/eslint/prettier all pass. diff --git a/.planning/phases/20-admin-member-editor-form-declutter/20-REVIEW.md b/.planning/phases/20-admin-member-editor-form-declutter/20-REVIEW.md index 2c82c1b..d31a67e 100644 --- a/.planning/phases/20-admin-member-editor-form-declutter/20-REVIEW.md +++ b/.planning/phases/20-admin-member-editor-form-declutter/20-REVIEW.md @@ -12,8 +12,8 @@ files_reviewed_list: findings: critical: 0 warning: 0 - info: 1 - total: 1 + info: 0 + total: 0 status: clean ---