luckberg/familysync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(20): mark IN-04 resolved — review fully clean

Browse Source 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Lucas Berger
2026-06-18 18:22:43 -04:00
co-authored by Claude Opus 4.8
parent 5161bd39c2
commit 8829fd22b5
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.planning/phases/20-admin-member-editor-form-declutter/20-REVIEW-FIX.md
+5 -5
View File
@@ -52,8 +52,8 @@ independently confirmed 0 critical / 0 warning remain.
## Introduced during fixes (caught by iteration-2 re-review)
- **IN-04 (Info, open):** The no-op profile-save path (`mutationFn` returns early on an
empty payload) still triggers `onSuccess`, so the "Profile saved." toast fires and the
`['admin','members']` query refetches even when nothing changed. Cosmetic. Fix: skip the
toast/refetch when the computed payload is empty. Not auto-applied — re-review returned
`status: clean` (no critical/warning), so the `--auto` loop exited before a third pass.
- **IN-04 (Info, resolved):** The no-op profile-save path (`mutationFn` returns early on an
empty payload) triggered `onSuccess`, firing the "Profile saved." toast and refetching the
`['admin','members']` query even when nothing changed. Fixed in `5161bd3` — `mutationFn`
now returns a `changed` flag and `onSuccess` skips the toast/refetch when no write occurred.
Typecheck/eslint/prettier all pass.