Commit Graph

95 Commits

Author SHA1 Message Date
Lucas Berger f071a949b1 docs(10.1): research phase domain
Phase 10.1: Aggressive Workflow Modularization
- Standard stack identified (Execute Workflow nodes, sub-workflow patterns)
- Architecture patterns documented (input contracts, error handling, routing)
- Pitfalls catalogued (memory issues, data references, error gaps, circular deps)
- Analyzed existing workflows (192 nodes main, 3 sub-workflows)
- Validated patterns against n8n docs and community best practices
- Confidence: HIGH (grounded in existing implementations + locked user decisions)
2026-02-04 20:14:22 -05:00
Lucas Berger 8e372dd8ed wip: 10.1-aggressive-workflow-modularization paused at context gathered
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 17:01:32 -05:00
Lucas Berger 9285f3e011 docs(10.1): capture phase context
Phase 10.1: Aggressive Workflow Modularization
- Implementation decisions documented
- Phase boundary established
- Fixed misnamed phase directories (10.1/10.2)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 17:00:37 -05:00
Lucas Berger f7859fc3c4 docs(phase-10): complete workflow modularization phase
All 7 plans executed and verified:
- 3 sub-workflows (Update, Actions, Logs)
- UAT gaps closed (race conditions, data chains, fuzzy matching)
- Main workflow: 209 → 192 nodes (-8%)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 16:05:06 -05:00
Lucas Berger b156fe48cf docs(10-07): complete UAT gap closure plan
Tasks completed: 5/5
- Fix text update race condition (remove parallel message)
- Fix batch update data chain (Build Progress Message reference)
- Fix batch action data chain (Build Progress Message reference)
- Add fuzzy matching to logs and fix chatId reference
- Add timestamp to logs refresh for message not modified error

SUMMARY: .planning/phases/10-workflow-modularization/10-07-SUMMARY.md
2026-02-04 16:01:49 -05:00
Lucas Berger 5a6b6e3e85 docs(10): create UAT gap closure plan 10-07
Phase 10 UAT revealed 5 gaps:
- Text update race condition (parallel message send)
- Batch update/action data chain broken ($json vs Build Progress Message)
- Logs fuzzy matching missing
- Logs refresh "message not modified" error

10-07-PLAN.md addresses all gaps in 5 tasks.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 15:54:02 -05:00
Lucas Berger ff675b7e19 test(phase-10): complete UAT - 4 passed, 5 issues
Issues found:
1. Text update sends duplicate messages (sub-workflow + main)
2. Batch update broken - data chain broken after Edit Progress Message
3. Batch actions broken - same data chain issue
4. Logs text command - no fuzzy matching, chatId not preserved
5. Logs refresh - doesn't handle 'message not modified' error

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 15:50:20 -05:00
Lucas Berger 1d55988aff docs(phase-10): complete workflow modularization phase
Phase 10 achievements:
- 3 sub-workflows: Update, Actions, Logs (all deployed)
- Main workflow: 209 → 192 nodes (-8%)
- Consolidated all container operations
- Removed old batch inline path
- Modernized callback formats

Deferred to Phase 10.1: Aggressive modularization (50-80 node target)
Added Phase 10.2: Better Logging & Log Management

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 15:10:19 -05:00
Lucas Berger e160b3e1cd docs(10-06): complete remediation plan
Tasks completed: 4/5 (1 skipped - path still needed)
- Fix batch actions routing to use sub-workflow
- Wire logs sub-workflow (deployment documented)
- Remove Python helper scripts (6 files, 1468 lines)
- Task 3 skipped: old inline path handles legacy callbacks

SUMMARY: .planning/phases/10-workflow-modularization/10-06-SUMMARY.md
2026-02-04 14:55:46 -05:00
Lucas Berger ed0e0e7ba2 docs(10-05): complete modularization plan
Tasks completed: 4/4
- Wire batch update to Container Update sub-workflow
- Wire batch actions to Container Actions sub-workflow
- Extract logs flow to Container Logs sub-workflow
- Clean up and verify workflow

Results:
- Main workflow: 209 → 199 nodes (-10, -4.8%)
- Created n8n-container-logs.json sub-workflow (9 nodes)
- All batch operations use sub-workflows (eliminated duplicate logic)
- 9 sub-workflow calls total (3 for Update, 4 for Actions, 2 for Logs)

Phase 10 now COMPLETE.

SUMMARY: .planning/phases/10-workflow-modularization/10-05-SUMMARY.md
2026-02-04 14:00:33 -05:00
Lucas Berger 186f11362e chore(10-05): verify and document workflow refactoring
- Run cleanup and verification script
- No orphaned nodes found
- Workflow structure validated
- Final node count: 199 (reduced from 209, -4.8%)
- Add comprehensive deployment guide

Node composition:
- 79 code nodes
- 50 httpRequest nodes
- 27 telegram nodes
- 14 if nodes
- 10 switch nodes
- 9 executeCommand nodes
- 9 executeWorkflow nodes (sub-workflow calls)
- 1 telegramTrigger node

Note: Node count (199) is above target range (120-150) but achieves
primary goals of eliminating duplicate logic. Further optimization
possible (~40-45 nodes) by consolidating batch UI and confirmation flows.

Deployment requires importing n8n-container-logs.json and updating
the workflow ID in main workflow Execute Text/Inline Logs nodes.
2026-02-04 13:58:48 -05:00
Lucas Berger c7c23b77c3 docs(10): checkpoint - waves 1-3 complete, wave 4 pending
Completed:
- 10-01: Orphan cleanup (2 nodes removed)
- 10-02: Container Update sub-workflow (31 nodes)
- 10-03: Container Actions sub-workflow (8 nodes)
- 10-04: Integration verified with user

Pending:
- 10-05: Wire batch ops to sub-workflows, extract logs

Key fixes applied:
- n8n typeVersion 1.2 requires __rl resource locator format
- Docker 204 success detection via empty response check

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 13:46:48 -05:00
Lucas Berger b83f76b27b docs(10): add plan 10-05 for complete modularization
Wave 4 plan to finish workflow modularization:
- Wire batch update to Container Update sub-workflow
- Wire batch actions to Container Actions sub-workflow
- Extract logs flow to new Container Logs sub-workflow
- Target: reduce main workflow from 209 to ~120-140 nodes

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 13:43:09 -05:00
Lucas Berger d3c1525f53 docs(10-03): complete container actions sub-workflow plan
Tasks completed: 3/3
- Task 1: Create container-actions sub-workflow
- Task 2: Wire main workflow to use sub-workflow
- Task 3: Deploy verification (local checks passed)

SUMMARY: .planning/phases/10-workflow-modularization/10-03-SUMMARY.md

Note: Full deployment verification requires n8n access
User setup: Set CONTAINER_ACTIONS_WORKFLOW_ID env var in n8n
2026-02-04 13:12:36 -05:00
Lucas Berger 99cdb95482 docs(10-01): complete orphan node cleanup plan
Tasks completed: 2/2
- Identified 2 orphan nodes via BFS from Telegram Trigger
- Removed orphan nodes, deployed, verified working

SUMMARY: .planning/phases/10-workflow-modularization/10-01-SUMMARY.md
2026-02-04 13:03:50 -05:00
Lucas Berger c122803fad docs(10): create phase plan for workflow modularization
Phase 10: Workflow Modularization
- 4 plan(s) in 3 wave(s)
- Wave 1: Orphan cleanup (1 plan)
- Wave 2: Sub-workflow extraction (2 plans parallel)
- Wave 3: Integration verification (1 plan)
- Ready for execution

Plans:
- 10-01: Remove 8 orphan nodes
- 10-02: Extract container-update sub-workflow (DEBT-03)
- 10-03: Extract container-actions sub-workflow
- 10-04: Integration verification with user checkpoint

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 11:39:54 -05:00
Lucas Berger a8e947ec95 docs: split Phase 10 into modularization and update all
Phase 10: Workflow Modularization (MOD-01, MOD-02, DEBT-03)
Phase 11: Update All & Callback Limits (BATCH-04-07)
Phase 12: Polish & Audit (UNR-01, ENV-01, ENV-02, DEBT-02)
Phase 13: Documentation Overhaul (DEBT-01)

12 requirements across 4 phases.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 11:23:19 -05:00
Lucas Berger 63df54e8e3 docs: formalize v1.2 requirements and roadmap
12 requirements across 3 phases:
- Phase 10: Modularization, update all, callback limits (7 reqs)
- Phase 11: Unraid sync, env audit, tech debt (4 reqs)
- Phase 12: Documentation overhaul (1 req)

Removed WEB-01 (webhook fix) - already resolved.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 11:21:31 -05:00
Lucas Berger 6a0551e0d6 chore: archive v1.1 audit and add tech debt to Phase 11
Archived:
- milestones/v1.1/v1.1-MILESTONE-AUDIT.md
- milestones/v1.1/INTEGRATION-CHECK.md

Updated:
- ROADMAP.md: Added v1.1 tech debt to Phase 11
- STATE.md: Updated with tech debt tracking

Tech debt items added to Phase 11:
- README.md documentation (still shows direct socket)
- Duplicate --max-time flags in image pull
- Update flow duplication between single/batch paths

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 11:16:03 -05:00
Lucas Berger b89f78db21 chore: complete v1.1 milestone
Archived:
- milestones/v1.1-ROADMAP.md
- milestones/v1.1-REQUIREMENTS.md

Deleted (fresh for next milestone):
- REQUIREMENTS.md

Updated:
- MILESTONES.md (new v1.1 entry)
- PROJECT.md (requirements → Validated, updated current state)
- ROADMAP.md (v1.1 collapsed, v1.2 phases added)
- STATE.md (reset for v1.2)

v1.1 shipped: Inline keyboard UX and Docker security hardening
- Phases 6-9 complete (11 plans)
- 4 requirements deferred to v1.2 (UNR-01, ENV-01, ENV-02, WEB-01)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 10:55:26 -05:00
Lucas Berger fa7c60394e docs(09): complete batch operations phase verification
- Created 09-04-SUMMARY.md with verification results
- Documented 5 bugs fixed during verification
- All batch operations tested and working
- Update all testing deferred (Unraid UI issue)
- Updated STATE.md to reflect phase completion

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 10:49:35 -05:00
Lucas Berger 8b231bbbb5 docs(09-04): note 64-byte callback_data limitations
- Long container names hit limit
- Batch select limited to ~2 containers with current format
- Consider short IDs or server-side state in Phase 9.1

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 10:25:24 -05:00
Lucas Berger 893a37e9c9 chore(09-04): defer batch Update to Phase 9.1
- Remove Update button from batch select (not implemented)
- Document in STATE.md: batch update needs sub-workflow modularization
- Batch Start and Stop work; Update requires complex 5-step sequence

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 10:24:08 -05:00
Lucas Berger 652d877ce1 docs(09-04): add comprehensive test plan for batch operations
- 21 test cases across 5 suites (text commands, update all, multi-select, errors, regression)
- Deployment steps for n8n workflow import
- Success criteria mapping to tests
- Test execution log template with issue tracking
- Covers all BAT-01 through BAT-06 requirements
2026-02-04 08:22:15 -05:00
Lucas Berger 93be20d9c4 docs(09-03): complete update all and multi-select plan
Tasks completed: 2/2
- Task 1: Update all command with availability check
- Task 2: Inline keyboard multi-select for batch operations

SUMMARY: .planning/phases/09-batch-operations/09-03-SUMMARY.md
Phase 9 complete: 3/3 plans done
2026-02-04 08:19:00 -05:00
Lucas Berger 1561d1a13a wip: batch-operations paused at plan 2/4 (waves 1-2 complete) 2026-02-03 21:35:58 -05:00
Lucas Berger 3e5fa5d8bd docs(09-02): complete batch execution and progress plan
Tasks completed: 3/3
- Add Loop Over Items for sequential batch execution
- Add per-container progress updates and action execution
- Add batch summary with failure emphasis

SUMMARY: .planning/phases/09-batch-operations/09-02-SUMMARY.md
2026-02-03 21:35:08 -05:00
Lucas Berger 1274eab438 docs(09-01): complete batch command parsing plan
Tasks completed: 3/3
- Task 1: Add batch command detection and parsing
- Task 2: Add container name matching with exact-match priority
- Task 3: Wire batch routing and add batch stop confirmation

SUMMARY: .planning/phases/09-batch-operations/09-01-SUMMARY.md
2026-02-03 21:24:13 -05:00
Lucas Berger 59ed1245c2 docs(09.1): insert modular sub-workflows phase
- Add Phase 9.1 between Phase 9 and Phase 10
- Update Phase 10 dependency to Phase 9.1
- Create phase directory structure

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 21:10:02 -05:00
Lucas Berger a409671dc6 docs(09): create phase plan
Phase 09: Batch Operations
- 4 plans in 4 waves
- 3 autonomous, 1 with checkpoint
- Ready for execution

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 21:01:06 -05:00
Lucas Berger 3ca89c3815 docs(09): research phase domain
Phase 9: Batch Operations
- Standard stack identified (Loop Over Items, If Error node, editMessageText)
- Sequential execution patterns documented
- Error handling with continue-on-failure
- Multi-select keyboard toggle pattern
- Rate limiting and callback_data constraints
- Fuzzy matching with exact match priority
2026-02-03 20:52:50 -05:00
Lucas Berger 13d27fd2d1 docs(09): capture phase context
Phase 09: Batch Operations
- Implementation decisions documented
- Phase boundary established
2026-02-03 20:44:58 -05:00
Lucas Berger 03e56503de docs(08): complete Phase 8 with verification summary
- Update STATE.md with Phase 8 completion status
- Add 08-03-SUMMARY.md documenting bug fixes and verification
- Remove .continue-here checkpoint file
- Record key decisions from verification session

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 20:32:15 -05:00
Lucas Berger 1331ee1331 wip(08): paused at verification checkpoint - workflow fixes in progress 2026-02-03 17:04:12 -05:00
Lucas Berger a6548b300f docs(08-02): complete action execution plan
Tasks completed: 2/2
- Task 1: Route Action Callbacks to Container Operations
- Task 2: Add Confirmation Flow for Dangerous Actions

SUMMARY: .planning/phases/08-inline-keyboard-infrastructure/08-02-SUMMARY.md

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 16:29:42 -05:00
Lucas Berger 1a3feecd91 docs(08-01): complete container list keyboard plan
Tasks completed: 3/3
- Task 1: Add Container List Inline Keyboard
- Task 2: Add Container Submenu with Action Buttons
- Task 3: Handle List Pagination Callbacks

SUMMARY: .planning/phases/08-inline-keyboard-infrastructure/08-01-SUMMARY.md
2026-02-03 16:19:51 -05:00
Lucas Berger ecd02a4b0e docs(08): create inline keyboard infrastructure plans
Phase 8: Inline Keyboard Infrastructure
- 3 plans in 3 waves (sequential dependency)
- Plan 01: Container list keyboard and submenu navigation
- Plan 02: Action execution and confirmation flow
- Plan 03: Progress feedback and completion messages

Covers KEY-01 through KEY-05 requirements.
Ready for execution.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 11:44:46 -05:00
Lucas Berger fe4c19c7c6 docs(08): research phase domain
Phase 8: Inline Keyboard Infrastructure
- Standard stack identified (HTTP Request + Telegram API)
- Architecture patterns documented (5 core patterns)
- Pitfalls catalogued (5 critical issues)
- n8n-specific workarounds for dynamic keyboards
2026-02-03 11:39:09 -05:00
Lucas Berger 6679fb7cf4 docs(08): capture phase context
Phase 08: Inline Keyboard Infrastructure
- Implementation decisions documented
- Phase boundary established

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 11:32:08 -05:00
Lucas Berger d933663bf5 test(07): complete UAT - 9 passed, 0 issues
All Socket Security phase tests verified:
- Proxy container running
- All 6 bot commands work through proxy
- Socket mount removed from n8n
- Dangerous APIs blocked by default

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 11:21:36 -05:00
Lucas Berger 24cc41b9fa docs(07): complete Socket Security phase
- SEC-01 through SEC-04 requirements verified and marked complete
- Phase 7 marked complete in ROADMAP.md
- 3/3 plans executed successfully

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 11:12:07 -05:00
Lucas Berger b02819434f fix(07-02): remove duplicate timeout on image pull
- Image pull had --max-time 600 --max-time 5 (second wins = 5s timeout)
- Removed duplicate, keeping 600s for large image pulls
- Added WEB-01 requirement for webhook fix in Phase 10
- Created 07-02-SUMMARY.md and 07-VERIFICATION.md

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 11:11:39 -05:00
Lucas Berger 26aacff444 docs(07-03): complete API blocking verification plan
Tasks completed: 2/2
- Test blocked endpoints return 403
- Document security configuration

SUMMARY: .planning/phases/07-socket-security/07-03-SUMMARY.md
2026-02-03 09:11:08 -05:00
Lucas Berger 208591dea8 docs(07-01): complete proxy deployment plan
Tasks completed: 2/2
- Install and Configure docker-socket-proxy (user action)
- Verify Proxy Connectivity (network config validation)

SUMMARY: .planning/phases/07-socket-security/07-01-SUMMARY.md
2026-02-03 09:06:48 -05:00
Lucas Berger 1a8749cceb test(06): complete UAT - 4 passed, 0 issues
Verified all n8n API capabilities:
- Authentication with X-N8N-API-KEY header
- Read workflow JSON (96 nodes)
- Update workflow via PUT
- View execution history

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 08:55:31 -05:00
Lucas Berger fef21fd39a fix(07): revise plans based on checker feedback
- Plan 02: Added Task 4 (checkpoint:human-action) to remove docker.sock
  volume mount from n8n container after verifying proxy works
- Plan 02: Added must_have truth for docker.sock removal (SEC-02 complete)
- Plan 03: Removed "Create API returns 403" from must_haves - container
  create is intentionally ALLOWED for update command functionality
- Plan 03: Added rationale explaining why container create is needed
- Clarified that blocked APIs are: exec, build, commit (not create)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 08:48:37 -05:00
Lucas Berger f539bcbba4 docs(07): create phase plan for Socket Security
Phase 07: Socket Security
- 3 plan(s) in 2 wave(s)
- Wave 1: 07-01 (deploy proxy - checkpoint)
- Wave 2: 07-02 (migrate workflow), 07-03 (verify blocking) - parallel
- Ready for execution

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 08:45:04 -05:00
Lucas Berger 1432d4feb2 docs(07): research phase domain
Phase 07: socket-security
- Standard stack identified
- Architecture patterns documented
- Pitfalls catalogued

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 08:40:04 -05:00
Lucas Berger e17c5bf0d4 docs(07): capture phase context
Phase 07: Socket Security
- Implementation decisions documented
- Phase boundary established
2026-02-03 08:33:57 -05:00
Lucas Berger 5aa07e8dfa docs(phase-6): complete n8n API Access phase
- All 4 API requirements verified (API-01 through API-04)
- Phase goal achieved: Claude Code can programmatically read, update, and test workflows
- Verification passed: 4/4 must-haves confirmed

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 08:21:34 -05:00