From b74fb3c19c6300eaab137b553f80936268b39676 Mon Sep 17 00:00:00 2001 From: Lucas Berger Date: Sun, 8 Feb 2026 09:32:43 -0500 Subject: [PATCH] test(10.1): diagnose 4 UAT issues with root causes - Gap 1: Format Stop/Start/Restart missing statusCode 304 check - Gap 2: Build Batch Keyboard reads action instead of actionType - Gap 3: /list not implemented in Keyword Router (minor) - Gap 4: Build Cancel Return Submenu references wrong predecessor Co-Authored-By: Claude Opus 4.6 --- .../10.1-UAT.md | 43 +++++++++++-------- 1 file changed, 26 insertions(+), 17 deletions(-) diff --git a/.planning/phases/10.1-aggressive-workflow-modularization/10.1-UAT.md b/.planning/phases/10.1-aggressive-workflow-modularization/10.1-UAT.md index 9bafe32..7e18afc 100644 --- a/.planning/phases/10.1-aggressive-workflow-modularization/10.1-UAT.md +++ b/.planning/phases/10.1-aggressive-workflow-modularization/10.1-UAT.md @@ -1,5 +1,5 @@ --- -status: complete +status: diagnosed phase: 10.1-aggressive-workflow-modularization source: [10.1-02-SUMMARY.md, 10.1-03-SUMMARY.md, 10.1-04-SUMMARY.md, 10.1-05-SUMMARY.md, 10.1-06-SUMMARY.md] started: 2026-02-08T14:20:00Z @@ -97,37 +97,46 @@ skipped: 0 reason: "User reported: Booklore is currently stopped. I entered stop book and I get a failure message instead of container is already stopped" severity: major test: 2 - root_cause: "" - artifacts: [] - missing: [] - debug_session: "" + root_cause: "Format Stop Result (and Start/Restart) in n8n-actions.json only checks response.message/response.error but not response.statusCode. Docker returns HTTP 304 for already-stopped containers. With onError:continueRegularOutput, the 304 passes through but isn't detected as 'already stopped'." + artifacts: + - path: "n8n-actions.json" + issue: "Format Stop Result, Format Start Result, Format Restart Result nodes missing statusCode check" + missing: + - "Add statusCode 304 check: treat as success with 'already stopped/started' message" + - "Also handle 404 (not found) and 500 (server error) distinctly" - truth: "Multiple container matches show disambiguation keyboard for user selection" status: failed reason: "User reported: I do get a 'found multiple containers' message, but the message says multiple all and there's no keyboard letting me choose" severity: major test: 3 - root_cause: "" - artifacts: [] - missing: [] - debug_session: "" + root_cause: "Build Batch Keyboard node in n8n-workflow.json reads $json.action (which is 'multiple' — the routing label) instead of $json.actionType (which contains the actual action like 'stop'). This causes message text 'multiple all?' and callback_data 'bexec:multiple:...' which won't be recognized by callback handler." + artifacts: + - path: "n8n-workflow.json" + issue: "Build Batch Keyboard node uses $json.action instead of $json.actionType" + missing: + - "Change const action = $json.action to const action = $json.actionType in Build Batch Keyboard" - truth: "/list command shows container list" status: failed reason: "User reported: list returns the commands available, not a list of anything" severity: minor test: 6 - root_cause: "" - artifacts: [] - missing: [] - debug_session: "" + root_cause: "The /list command was never implemented in the Keyword Router. The router only recognizes: status, restart, start, stop, update, update all, logs. Unrecognized commands fall through to 'Show Menu' (help text). The 'status' command with no args correctly shows the container list." + artifacts: + - path: "n8n-workflow.json" + issue: "Keyword Router has no route for 'list' command" + missing: + - "Either add 'list' as alias for 'status' in Keyword Router, or document that 'status' is the correct command" - truth: "Cancel button on confirmation dialog returns to container status view" status: failed reason: "User reported: Cancel from the confirmation dialog does not work" severity: major test: 11 - root_cause: "" - artifacts: [] - missing: [] - debug_session: "" + root_cause: "Build Cancel Return Submenu node uses hardcoded $('Prepare Cancel Return').item.json reference. When cancel comes from confirmation dialog, data flows through Prepare Cancel From Confirm instead, so the node reference fails. Both paths output same data structure but the node only references one." + artifacts: + - path: "n8n-workflow.json" + issue: "Build Cancel Return Submenu node references wrong predecessor for confirmation cancel path" + missing: + - "Change $('Prepare Cancel Return').item.json to $input.item.json in Build Cancel Return Submenu"