Lucas BergerandClaude Opus 4.8
c7955a46b9
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
8.6 KiB
8.6 KiB
phase, verified, status, score, overrides_applied
| phase | verified | status | score | overrides_applied |
|---|---|---|---|---|
| 14-desktop-e2e-coverage | 2026-06-12T00:00:00Z | passed | 5/5 must-haves verified | 0 |
Phase 14: Desktop E2E Coverage Verification Report
Phase Goal: The Phase 8 regression gate exercises the desktop layout and flows, not just mobile. A desktop Playwright project (devices['Desktop Chrome'], no touch, wide viewport) is added to apps/pwa/playwright.config.ts, and the existing mobile-authored specs are reviewed/adjusted (or appropriately skipped) so pnpm test:e2e passes on a no-touch desktop viewport as well as the iphone/pixel profiles.
Verified: 2026-06-12
Status: passed
Re-verification: No — initial verification
Goal Achievement
Observable Truths
| # | Truth | Status | Evidence |
|---|---|---|---|
| 1 | A desktop Playwright project (Desktop Chrome, 1280×720, no hasTouch) exists in playwright.config.ts (SC-1, D-06) |
VERIFIED | name: 'desktop' at line 58; ...devices['Desktop Chrome'] at line 60; serviceWorkers: 'block' at line 61; no baseURL inside the desktop project block (inherited from top-level use); comment explicitly states "no hasTouch (D-06)" |
| 2 | pnpm --filter @familysync/pwa test:e2e exits 0 on all three projects: iphone, pixel, desktop (SC-2) |
VERIFIED | CI run #32 (PR #10 → main): harness job ran pnpm --filter @familysync/pwa test:e2e --reporter=list,html with no --project filter — all three projects execute; SUMMARY records 85 passed / 5 skipped / 0 failed; commits d3bc696, 2903599, bfc49d1 are present in git history |
| 3 | The two mobile-only assertions (BottomTabBar safe-area in-viewport, 56×56 FAB geometry) are skipped on desktop only, not deleted, and still run on iphone/pixel (SC-2, D-01, D-02) | VERIFIED | grep -c "testInfo.project.name === 'desktop'" layout.spec.ts == 3 (three skip guards: line 66, 99, 161); toBeGreaterThanOrEqual(56) still present at lines 107–108; toBeGreaterThanOrEqual(44) still present at lines 50–51, 59–60, 94–95, 127, 147–148, 156–157, 248; no test body removed |
| 4 | Cross-cutting tests (no-overflow, nav-landmark visible, tap targets ≥44px, populated/empty/error states) run unchanged on desktop (SC-2, D-04); D-04 parity (New Event toolbar button ≥44px) asserting only on desktop | VERIFIED | D-04 parity test at lines 114–128 guarded by testInfo.project.name !== 'desktop' (confirmed by grep count == 1); overflow, nav-landmark, calendar/lists populated/error/empty state tests have no project-name guards and run on all three profiles; calendar.spec.ts and lists.spec.ts contain no structural test changes |
| 5 | The desktop gate is blocking — no continue-on-error carve-out (SC-3, D-03) |
VERIFIED | grep "continue-on-error" .gitea/workflows/ci.yml returns nothing; harness step runs pnpm --filter @familysync/pwa test:e2e (all projects) with no isolation or continue-on-error; Chromium engine already installed via playwright install --with-deps webkit chromium (line 242); CI step name updated to name all three profiles (line 255, cosmetic only) |
Score: 5/5 truths verified
Required Artifacts
| Artifact | Expected | Status | Details |
|---|---|---|---|
apps/pwa/playwright.config.ts |
desktop project entry mirroring iphone/pixel | VERIFIED | name: 'desktop', ...devices['Desktop Chrome'], serviceWorkers: 'block'; no baseURL in project block; header jsdoc lists three profiles |
apps/pwa/e2e/layout.spec.ts |
desktop-skip guards on two mobile-only tests + D-04 parity assertion | VERIFIED | Exactly 3 test.skip(testInfo.project.name === 'desktop', ...) guards; 1 test.skip(testInfo.project.name !== 'desktop', ...) parity guard; all prior mobile assertions intact |
apps/pwa/e2e/README.md |
harness docs listing the desktop profile | VERIFIED | Line 1 preamble mentions "Desktop Chrome (1280×720)"; --project=desktop example at line 42; run commands block names all three profiles |
Key Link Verification
| From | To | Via | Status | Details |
|---|---|---|---|---|
apps/pwa/playwright.config.ts |
devices['Desktop Chrome'] |
spread into desktop project use block |
VERIFIED | Line 60: ...devices['Desktop Chrome'] |
apps/pwa/e2e/layout.spec.ts |
testInfo.project.name |
test.skip first-statement guard keyed on === 'desktop' |
VERIFIED | Three guards at lines 66–69, 99–102, 161–164; all use first-statement form inside async ({ page }, testInfo) |
| CI harness | all three projects | pnpm --filter @familysync/pwa test:e2e with no --project filter |
VERIFIED | .gitea/workflows/ci.yml line 293; picks up desktop automatically |
Data-Flow Trace (Level 4)
Not applicable. Phase produces only test-harness artifacts — no runtime components rendering dynamic data.
Behavioral Spot-Checks
| Behavior | Command | Result | Status |
|---|---|---|---|
| desktop project resolves in Playwright | grep -c "name: 'desktop'" apps/pwa/playwright.config.ts |
1 | PASS |
| Exactly 3 desktop skip guards | grep -c "testInfo.project.name === 'desktop'" apps/pwa/e2e/layout.spec.ts |
3 | PASS |
| D-04 parity guard present | grep -c "testInfo.project.name !== 'desktop'" apps/pwa/e2e/layout.spec.ts |
1 | PASS |
| Mobile 56px FAB assertions intact | grep "toBeGreaterThanOrEqual(56)" apps/pwa/e2e/layout.spec.ts |
2 matches (lines 107–108) | PASS |
No desktop.spec.ts created (D-01) |
ls apps/pwa/e2e/desktop.spec.ts |
NOT FOUND | PASS |
No continue-on-error in CI harness |
grep "continue-on-error" .gitea/workflows/ci.yml |
no output | PASS |
| Commits from SUMMARY exist | git log --oneline d3bc696 2903599 bfc49d1 |
all three found in history | PASS |
Probe Execution
No probes declared in PLAN or found at scripts/*/tests/probe-*.sh. Skipped.
Requirements Coverage
| Requirement | Description | Status | Evidence |
|---|---|---|---|
| SC-1 | desktop project (Desktop Chrome, 1280×720, no hasTouch) exists in playwright.config.ts |
SATISFIED | Verified at playwright.config.ts:56–63 |
| SC-2 | Existing e2e specs pass (or justifiably skipped) on desktop; pnpm test:e2e green on all three projects |
SATISFIED | 3 mobile-geometry tests desktop-skipped with factual reasons; D-04 parity added; CI run #32 green |
| SC-3 | Desktop gate is blocking in CI (no continue-on-error), runs automatically, specs deterministic |
SATISFIED | No continue-on-error in CI yml; harness runs all projects via single test:e2e invocation with no filter |
Anti-Patterns Found
| File | Pattern | Severity | Impact |
|---|---|---|---|
apps/pwa/e2e/layout.spec.ts:83–96 |
PhoneNav header is visible and PhoneNav settings button tests run unguarded on desktop, silently re-targeting DesktopNav elements (WR-01 from code review) |
INFO | Tests pass by coincidence on desktop; a PhoneNav-specific regression would not be caught on the desktop profile. Not a blocker — both tests still pass and the phase goal (desktop gate green) is achieved. Flagged in 14-REVIEW.md. |
apps/pwa/e2e/calendar.spec.ts:16 / lists.spec.ts:19 |
Header comment claims "all tests pass unchanged" without qualifying the month-grid/DesktopNav view divergence on desktop (WR-02, WR-03 from code review) | INFO | Comment is misleading but not a correctness failure. No test is broken. |
No TBD / FIXME / XXX markers found in any phase-modified file.
Human Verification Required
None. All must-haves are verifiable programmatically. CI evidence (PR #10, run #32) confirms full-suite green. No visual, real-time, or device-only checks are required to confirm the phase goal.
Gaps Summary
No gaps. All five must-have truths are verified by direct codebase inspection:
playwright.config.tscontains the correctdesktopproject entry with all required properties.layout.spec.tshas exactly the right guard count (3 desktop-skip, 1 desktop-only parity) and all prior mobile assertions are intact.- No
desktop.spec.tswas created. - The CI harness runs all three projects without
continue-on-error. - README and spec headers document the desktop profile.
The code review (14-REVIEW.md) identified three warnings (WR-01 misleading test names, WR-02 month-grid claim, WR-03 comment accuracy) and three info items (IN-01 serviceWorkers hoisting, IN-02 missing auth-wait in parity test, IN-03 implicit viewport assumption). None of these affect the phase goal or the correctness of the desktop gate. They are documentation/quality items for a follow-up if desired.
Verified: 2026-06-12 Verifier: Claude (gsd-verifier)