Files

T

Lucas Berger 982438dc10 style(13-03): apply Prettier formatting across repo

Mechanical reformat — no logic changes. 398 files changed, 19125
insertions(+), 16457 deletions(-). Prettier 3.8.4 with .prettierrc
(singleQuote:true, semi:true, tabWidth:2, trailingComma:all,
printWidth:100). Isolated per D-13-08 for reviewability.

2026-06-11 20:35:18 -04:00

7.7 KiB

Raw Blame History

phase, plan, subsystem, tags, dependency_graph, tech_stack, key_files, key_decisions, patterns-established, requirements-completed, duration, completed

phase

plan

subsystem

Phase 07 Plan 04: calendar.spec.ts + lists.spec.ts State Coverage Summary

calendar.spec.ts and lists.spec.ts asserting populated/error/empty states on iPhone/WebKit and Pixel/Chromium, with TEST-02 DEV_AUTH_BYPASS and service-worker-block precondition assertions at runtime.

Performance

Duration: 22 min
Started: 2026-06-11T05:49:00Z
Completed: 2026-06-11T06:11:47Z
Tasks: 2
Files modified: 2

Accomplishments

apps/pwa/e2e/calendar.spec.ts — 8 tests per profile (16 total) covering: TEST-02 auth-bypass reach + SW-controller null assertion; populated state (Schedule-X grid visible, EmptyState absent, no overflow); error state (mocked /api/events* 500, 'Couldn't load events' heading, Retry ≥44px, no overflow, mock unrouted)
apps/pwa/e2e/lists.spec.ts — 6 tests per profile (12 total) covering: populated state (seeded 'E2E Grocery List' card by aria-label, listitem count ≥1, 'No lists yet' absent, no overflow); empty state (network-simulated via page.route to 200 [], 'No lists yet' + 'Tap + to create' visible, no overflow, mock unrouted)
All 28 tests pass on both iphone (WebKit) and pixel (Chromium); pnpm --filter @familysync/pwa typecheck exits 0; no absolute URLs; seeded DB not mutated by any spec

Task Commits

Task 1: calendar.spec.ts - 17b625b (feat)
Task 2: lists.spec.ts - b074b4a (feat)

Files Created/Modified

apps/pwa/e2e/calendar.spec.ts — TEST-01 + TEST-02 assertions for /calendar (populated, error, auth-bypass, SW-block)
apps/pwa/e2e/lists.spec.ts — TEST-01 assertions for /lists (populated and network-simulated empty)

Decisions Made

D-04-SCHEDULE-X-LOCATOR: page.locator('.sx-react-calendar-wrapper') used to assert calendar grid — the Schedule-X React adapter emits a div with this class but no semantic ARIA role. This is documented in apps/pwa/src/styles/index.css as the canonical outer wrapper class. No data-testid added to source code.
D-04-POPULATED-NO-CHIP: Populated calendar test asserts grid visible + 'Nothing here' absent rather than the seeded event chip text 'Seeded Test Event'. Schedule-X renders only events in the current view window; the seed event is tomorrow UTC but the default view and timezone rendering makes chip visibility date-dependent. The plan explicitly flagged this risk.
D-04-EMPTY-NETWORK-SIM: Lists empty state simulated with page.route('/api/lists', fulfill 200 { lists: [] }) before page.goto rather than by deleting the seeded row. This preserves the deterministic seed for parallel test workers and avoids DB state mutation in specs (D-06 / T-07-11).
D-04-LISTCARD-BUTTON: ListCard.tsx renders the card as <button aria-label="Open list: ..."> (not <a>), so the locator uses getByRole('button', { name: 'Open list: E2E Grocery List' }).

Deviations from Plan

None — plan executed exactly as written. All implementation choices were documented as decisions (listed above).

Known Stubs

None — both spec files are complete implementations with no placeholders.

Threat Surface Scan

No new network endpoints, auth paths, or schema changes. Both files are test-only.

Threat mitigations confirmed active:

T-07-09 (DEV_AUTH_BYPASS elevation): TEST-02 precondition spec asserts the bypass reached the authed PWA — confirms the dev-only guard is working. The spec does not enable the bypass; it depends on the running dev stack.
T-07-10 (OIDC mock spoofing): No storageState and no OIDC mock used — auth comes from the real DEV_AUTH_BYPASS middleware. Auth reach is asserted via nav landmark presence + URL hostname check (not a faked session).
T-07-11 (route mock leakage): Every page.route call in calendar.spec.ts and lists.spec.ts is paired with page.unroute immediately after the assertion block. Mocks are page-scoped and do not persist across test contexts.

Self-Check: PASSED

apps/pwa/e2e/calendar.spec.ts — exists
apps/pwa/e2e/lists.spec.ts — exists
Task 1 commit 17b625b — exists
Task 2 commit b074b4a — exists
28 tests passing on both profiles — verified by final combined run
pnpm --filter @familysync/pwa typecheck — exits 0
No absolute URLs: grep -cE "https?://localhost" e2e/calendar.spec.ts e2e/lists.spec.ts → both 0

7.7 KiB Raw Blame History