Phase 20: Admin Member Editor & Form Declutter #25

Merged
luckberg merged 37 commits from gsd/phase-20-admin-member-editor-form-declutter into main 2026-06-18 20:40:35 -04:00
2 changed files with 7 additions and 7 deletions
Showing only changes of commit 8829fd22b5 - Show all commits
@@ -52,8 +52,8 @@ independently confirmed 0 critical / 0 warning remain.
## Introduced during fixes (caught by iteration-2 re-review)
- **IN-04 (Info, open):** The no-op profile-save path (`mutationFn` returns early on an
empty payload) still triggers `onSuccess`, so the "Profile saved." toast fires and the
`['admin','members']` query refetches even when nothing changed. Cosmetic. Fix: skip the
toast/refetch when the computed payload is empty. Not auto-applied — re-review returned
`status: clean` (no critical/warning), so the `--auto` loop exited before a third pass.
- **IN-04 (Info, resolved):** The no-op profile-save path (`mutationFn` returns early on an
empty payload) triggered `onSuccess`, firing the "Profile saved." toast and refetching the
`['admin','members']` query even when nothing changed. Fixed in `5161bd3``mutationFn`
now returns a `changed` flag and `onSuccess` skips the toast/refetch when no write occurred.
Typecheck/eslint/prettier all pass.
@@ -12,8 +12,8 @@ files_reviewed_list:
findings:
critical: 0
warning: 0
info: 1
total: 1
info: 0
total: 0
status: clean
---