Commit Graph
622 Commits
Author SHA1 Message Date
Lucas Berger 44a9c307e2 fix(08-fix): WR-02 upload Playwright HTML report on harness failure 2026-06-11 19:26:28 -04:00
Lucas Berger 694253ecb0 docs(13): create phase plan — 3 plans (lint gate + Prettier format gate)
- 13-01: install ESLint v9/typescript-eslint/React/Prettier (pinned), flat config,
  package lint + root format scripts, root type:module; prove gate fails (SC-1)
- 13-02: fix all first-run violations across both apps, address-not-mask (D-13-05/06)
- 13-03: isolated Prettier reformat (D-13-08) + CI format:check step + green baseline (SC-2/SC-3)
- ROADMAP: add active Phase 13 entry + Progress row; mark backlog 999.16 promoted
2026-06-11 19:25:08 -04:00
Lucas Berger 2863025bcd docs(13): add pattern map 2026-06-11 19:18:46 -04:00
Lucas Berger bcc9682a01 docs(roadmap): promote Phases 13 (real lint gate) + 14 (desktop e2e) into v1.1; fold backlog 999.5 self-service onboarding into admin-credential phase
CI / fast-checks (pull_request) Successful in 50s
CI / api (pull_request) Successful in 1m1s
CI / harness (pull_request) Successful in 3m33s
2026-06-11 19:13:31 -04:00
luckberg b12e10d129 Merge pull request 'chore(ci): split publish into standalone push-only workflow + document release model' (#5) from gsd/quick-split-publish into main
Publish / publish (push) Successful in 7s
Reviewed-on: #5
2026-06-11 19:04:30 -04:00
Lucas Berger ee67dfecef docs(13): add research + validation strategy 2026-06-11 19:04:13 -04:00
Lucas Berger ef87a3edf6 docs(13): research phase — ESLint flat config + Prettier 2026-06-11 19:03:11 -04:00
Lucas Berger 2b6b0da939 docs(state): record phase 13 context session 2026-06-11 18:29:04 -04:00
Lucas Berger 8fbc68f993 docs(13): capture phase context 2026-06-11 18:28:58 -04:00
Lucas Berger 234384c142 docs(quick-260611-ozt): split publish job into standalone gitea workflow + document release model
CI / fast-checks (pull_request) Successful in 49s
CI / api (pull_request) Successful in 56s
CI / harness (pull_request) Successful in 3m22s
2026-06-11 18:08:27 -04:00
Lucas Berger 92353e1860 docs(260611-ozt): document release model in README Publishing/Releases section
- Add Publishing / Releases section covering auto-trigger, image tags,
  REGISTRY_PAT secret naming, branch-protection safety gate, and MILESTONE bump
- publish.yml already carries condensed header block (committed in prior task)
2026-06-11 18:06:46 -04:00
Lucas Berger bb331fd110 chore(260611-ozt): split publish job into standalone publish.yml
- Create .gitea/workflows/publish.yml (push-to-main only, name=Publish)
- Strip publish job, push trigger, and MILESTONE env from ci.yml
- Eliminates orphaned CI / publish (pull_request) status on PRs
- Preserves all three required PR status contexts unchanged
2026-06-11 18:06:46 -04:00
Lucas Berger e14054c264 docs(260611-ozt): pre-dispatch plan for split publish job into standalone gitea workflow 2026-06-11 18:02:57 -04:00
luckberg f153a72c36 Merge pull request 'docs(08): Phase 8 close-out — SUMMARY + VERIFICATION + tracking' (#4) from gsd/phase-08-gitea-ci into main
CI / fast-checks (push) Has been skipped
CI / api (push) Has been skipped
CI / harness (push) Has been skipped
CI / publish (push) Successful in 5s
2026-06-11 16:30:09 -04:00
Lucas Berger b1851f475e docs(08): SUMMARY + VERIFICATION — phase 8 complete, CI-01 + CI-02 delivered
CI / fast-checks (pull_request) Successful in 49s
CI / api (pull_request) Successful in 56s
CI / harness (pull_request) Successful in 3m23s
CI / publish (pull_request) Has been skipped
- 08-04-SUMMARY.md: publish job verified green (run #14), both tags pushed,
  security audit pass (PAT masked, --password-stdin), REGISTRY_PAT naming note
- 08-VERIFICATION.md: all six phase-8 ROADMAP criteria passed with evidence table
- REQUIREMENTS.md: CI-01 + CI-02 marked complete (checkboxes + traceability table)
- ROADMAP.md: phase 8 marked [x] complete (2026-06-11), 08-04 plan ticked
- STATE.md: phase complete, D-PAT-NAMING decision recorded, operator next steps updated
2026-06-11 16:17:53 -04:00
luckberg 98acff8108 Merge pull request 'Phase 8: Gitea CI — runner probe + PR gating jobs (fast-checks + api)' (#3) from gsd/phase-08-gitea-ci into main
CI / fast-checks (push) Has been skipped
CI / api (push) Has been skipped
CI / harness (push) Has been skipped
CI / publish (push) Successful in 1m7s
2026-06-11 16:11:41 -04:00
Lucas Berger 73eecf7559 fix(08-04): reference secrets.REGISTRY_PAT — Gitea reserves the GITEA_ prefix
CI / fast-checks (pull_request) Successful in 49s
CI / api (pull_request) Successful in 57s
CI / harness (pull_request) Successful in 3m30s
CI / publish (pull_request) Has been skipped
The registry PAT secret had to be named REGISTRY_PAT (Gitea forbids the GITEA_
prefix for secret names). Point the publish docker-login at secrets.REGISTRY_PAT.
2026-06-11 16:05:54 -04:00
Lucas Berger dcf42423a5 chore(08): remove throwaway runner-probe workflow before merge to main
CI / fast-checks (pull_request) Successful in 50s
CI / api (pull_request) Successful in 56s
CI / harness (pull_request) Successful in 3m27s
CI / publish (pull_request) Has been skipped
Probe answers are recorded in 08-01-SUMMARY; the probe is no longer needed and
should not live on main (it was workflow_dispatch-only/inert anyway).
2026-06-11 15:57:49 -04:00
Lucas Berger ebcc38d810 feat(08-04): publish job — build + push API image on merge to main
- Add publish job gated on push to refs/heads/main (never pull_request)
- docker login via --password-stdin with secrets.GITEA_REGISTRY_PAT (Pitfall 13)
- docker build --target production -f apps/api/Dockerfile . (repo-root context, T-08-10)
- Push :latest and :${MILESTONE}-${SHORT_SHA} tags per D-04
- docker logout in always() step to drop credential after push
- No dev-bypass flag in publish job (T-08-09 boundary)
2026-06-11 15:56:37 -04:00
Lucas Berger 212d8c1691 docs(08-03): SUMMARY — harness green, 58 specs both profiles on cold CI stack
- Run #11 (PR #3): 58 passed in 1.6 min (iphone/WebKit + pixel/Chromium)
- 4 infrastructure fixes: API-reap at step boundary, IPv4-first for Vite, dev-user FK seed, reporter double-forward via pnpm
- No Phase 7 harness file modified (phase boundary D-01/D-02 held)
- Advance position to 08-04 (publish job)
2026-06-11 15:52:15 -04:00
Lucas Berger 03e8088238 fix(08-03): call pwa test:e2e directly so --reporter forwards cleanly
CI / fast-checks (pull_request) Successful in 49s
CI / api (pull_request) Successful in 1m0s
CI / harness (pull_request) Successful in 3m26s
Run #10 cleared global-setup but playwright errored 'No tests found':
`pnpm test:e2e -- --reporter=list,html` routes through two pnpm script layers
(root→pwa) and the `--` survives into `playwright test -- --reporter=list,html`,
where playwright treats --reporter as a test-file filter. Call the pwa script
directly and append the flag without `--` (validated: 58 specs list vs 0).
2026-06-11 15:43:09 -04:00
Lucas Berger e486c6be9f fix(08-03): seed dev user id=1 — global-setup assumes it exists
CI / fast-checks (pull_request) Successful in 48s
CI / api (pull_request) Successful in 56s
CI / harness (pull_request) Failing after 2m0s
global-setup.ts seeds calendars/lists/events for user_id=1 but never creates
the user (DEV_AUTH_BYPASS injects DEV_USER in-memory only). On a fresh CI DB the
calendars INSERT IGNORE is silently skipped on the users FK → calendar 10 missing
→ calendar_events insert fails FK. Add an idempotent users(id=1) seed after
migrate (validated locally: full insert chain passes). No harness files changed.
2026-06-11 15:36:52 -04:00
Lucas Berger 73897407c7 fix(08-03): harness uses 127.0.0.1 + ipv4first — Vite is IPv4-only
CI / fast-checks (pull_request) Successful in 50s
CI / api (pull_request) Successful in 56s
CI / harness (pull_request) Failing after 1m49s
global-setup polls baseURL/health via Node fetch; the runner resolves localhost
to ::1 first, but Vite binds IPv4-only (127.0.0.1:5173), so localhost→::1:5173
→ ECONNREFUSED → health poll never returns 200. (curl passed for :3000 because
curl falls back IPv4↔IPv6 and the API is dual-stack; Node fetch does not.)
Proven: [::1]:5173 ECONNREFUSED vs 127.0.0.1:5173 200. Point PLAYWRIGHT_BASE_URL
at 127.0.0.1 and add --dns-result-order=ipv4first. No harness files changed.
2026-06-11 15:20:24 -04:00
Lucas Berger 53a989c3fb fix(08-03): keep API alive during harness — start API + run e2e in one step
CI / fast-checks (pull_request) Successful in 49s
CI / api (pull_request) Successful in 56s
CI / harness (pull_request) Failing after 2m50s
Run #7 harness failed: global-setup polled :5173/health (Vite proxy → :3000)
and never got 200. The API connected to the DB and :3000/health was green
during the separate 'Wait for API' step, but the bare-backgrounded node
process was reaped at the step boundary and was dead by the time the e2e step
ran (after the multi-minute browser install). Confirmed locally the API does
not self-crash (alive + healthy for 75s in-shell).

Install browsers first, then start the API and run Playwright in a SINGLE step
so the API stays a child of the test shell for the whole run; capture the test
exit code and kill the API after. No harness files touched.
2026-06-11 15:05:04 -04:00
Lucas Berger 71c89093b1 feat(08-03): add Playwright install + harness run (both profiles) + artifact upload
CI / fast-checks (pull_request) Successful in 48s
CI / api (pull_request) Successful in 56s
CI / harness (pull_request) Failing after 2m53s
- npx playwright install --with-deps webkit chromium from apps/pwa/ (D-PROBE-05)
- pnpm test:e2e -- --reporter=list,html overrides github reporter (Pitfall 5; Gitea ignores annotations)
- Both iphone (WebKit) + pixel (Chromium) profiles run (D-05; no --project filter)
- Step env: CI=true, PLAYWRIGHT_BASE_URL=http://localhost:5173, DEV_AUTH_BYPASS=true, NODE_ENV=development, DB_*
- On failure: upload apps/pwa/test-results/ via ChristopherHX/gitea-upload-artifact@v4 (D-06/D-PROBE-06)
- Always: kill API background process via /tmp/api.pid
- No edits to playwright.config.ts / global-setup.ts / vite.config.ts / specs (phase boundary)
2026-06-11 14:45:52 -04:00
Lucas Berger d55e347a09 feat(08-03): add harness job — DB + migrate + API background + :3000 readiness
- Add harness job to ci.yml (ubuntu-latest, pull_request, parallel with fast-checks + api)
- MariaDB 11 service container with healthcheck.sh readiness (same pattern as api job)
- mysql2 readiness poll (no mysql CLI in runner image, D-PROBE-03)
- db:migrate via drizzle-kit (never db:push, T-08-07)
- pnpm --filter @familysync/api build before starting (Pitfall 4)
- API background: DEV_AUTH_BYPASS=true inline on node line (Pitfall 8), NODE_ENV=development
- curl retry loop on localhost:3000/health, 60s deadline, kill+exit on timeout (D-02/T-08-08)
2026-06-11 14:45:07 -04:00
Lucas Berger 2a34a94cc6 docs(08): correct premature completion — phase 8 + CI-01 still in progress
CI / fast-checks (pull_request) Successful in 48s
CI / api (pull_request) Successful in 57s
Plans 08-03 (harness UI-regression job) and 08-04 (publish job) are not yet
built; CI-01's definition includes the harness step (08-03). Revert phase 8
and CI-01 from complete back to in-progress.
2026-06-11 14:42:33 -04:00
Lucas Berger 694ffe713b docs(08): commit phase research (was untracked) 2026-06-11 14:39:30 -04:00
Lucas Berger 78229168b9 docs(08-02): SUMMARY — PR gating jobs green on cold run 2026-06-11 14:37:32 -04:00
Lucas Berger 181d161da6 docs: add backlog 999.16 — wire real ESLint lint gate (deferred from phase 8) 2026-06-11 14:33:22 -04:00
Lucas Berger 0b148b96f8 chore(08-01): probe to manual-only (workflow_dispatch)
CI / fast-checks (pull_request) Successful in 48s
CI / api (pull_request) Successful in 57s
Stops the throwaway probe re-running on every push and contending with
ci.yml on the single runner. Fork answers already captured in 08-01-SUMMARY.
2026-06-11 14:29:38 -04:00
Lucas Berger dc31d4e1ec fix(ci): make root lint script a no-op-when-absent gate
pnpm -r lint exited 1 (ERR_PNPM_RECURSIVE_RUN_NO_SCRIPT) because no package
defines a lint script yet, failing the CI fast-checks job. Switch to
pnpm -r --if-present lint so it exits 0 today and gates automatically once a
lint script is added. (Lint tooling wiring remains out of scope.)
2026-06-11 14:29:08 -04:00
Lucas Berger c0f892cae5 fix(db): squash migrations to single baseline (cold-migrate was broken)
0000_easy_slipstream already created lists/list_shares/list_items and the
calendars unique constraint, but 0001_lists_schema re-created those tables and
0001_calendars_user_url_unique was an orphan (not in _journal) — so a cold
`drizzle-kit migrate` against an empty DB failed with ERROR 1050 'Table lists
already exists'. Dev only survived because its DB was built incrementally; CI
is the first cold migrate and exposed it.

Regenerated a single 0000_baseline.sql from schema.ts. Verified on a fresh
mariadb:11: migrate succeeds, schema is structurally identical to the running
dev DB, `drizzle-kit generate` reports no drift, and all 238 API tests pass.
Local dev DBs must be rebuilt (drop + db:migrate); no prod exists.
2026-06-11 14:28:08 -04:00
Lucas Berger 3343f36e97 feat(08-02): ci.yml api job with mariadb service
runner-probe / runner-probe (push) Successful in 1m47s
CI / fast-checks (pull_request) Failing after 22s
CI / api (pull_request) Failing after 26s
- api job: runs-on ubuntu-latest, if pull_request, parallel with fast-checks (no needs:)
- services: mariadb:11 with healthcheck.sh --connect --innodb_initialized options
  (--health-start-period=30s for MariaDB 11 InnoDB cold-start, --health-retries=10)
- DB_HOST: mariadb (Docker-executor confirmed by D-PROBE-02)
- Throwaway creds: familysync/testpass scoped to ephemeral service container (T-08-03)
- No actions/cache (D-PROBE-04)
- Node mysql2 readiness poll via --input-type=commonjs inline script, 90s deadline
  (no mysql CLI in runner image per D-PROBE-03; Pitfall 11 belt-and-suspenders)
- db:migrate (drizzle-kit migrate); drizzle push never used (T-08-04, MariaDB unsafe)
- pnpm --filter @familysync/api test: full DB-backed API test suite
2026-06-11 10:22:45 -04:00
Lucas Berger 667f01702c feat(08-02): ci.yml fast-checks job
- on: pull_request + push branches:[main]; workflow env MILESTONE: v1.1
- fast-checks job: runs-on ubuntu-latest, if pull_request
- Node 22 via actions/setup-node@v4 + corepack enable pnpm
- No actions/cache (D-PROBE-04: times out on this runner)
- pnpm install --frozen-lockfile, lint (no-op), typecheck, PWA unit tests
- DB-backed pnpm test intentionally absent from this job
2026-06-11 10:21:17 -04:00
Lucas Berger 087d9af117 docs(08-01): SUMMARY — probe fork answers recorded, plan complete
- Docker-executor mode confirmed; runs-on: ubuntu-latest (not self-hosted)
- MariaDB service container works; DB_HOST=mariadb; no mysql CLI in image
- actions/cache@v4 unreliable (timeout) — skip in Plans 02/03
- Playwright WebKit deps install cleanly; Phase-7 harness CI-feasible
- ChristopherHX/gitea-upload-artifact@v4 confirmed; actions/upload-artifact@v4 broken
- ${GITHUB_SHA:0:7} valid for image tags
- STATE.md: plan 08-01 complete, position advanced to 08-02 (Wave 2)
- ROADMAP.md: 08 phase progress updated (1/4 plans complete)
2026-06-11 10:16:26 -04:00
Lucas Berger 134d4db08a fix(08-01): probe runs-on ubuntu-latest — runner has no self-hosted label
runner-probe / runner-probe (push) Successful in 5m33s
The act_runner advertises ubuntu-latest/ubuntu-24.04/ubuntu-22.04; runs-on:
self-hosted matched no runner and the probe job stayed queued. Switch the
probe (and the plan key-link) to ubuntu-latest. ci.yml (Plans 02-04) must
use the same label.
2026-06-11 10:04:41 -04:00
Lucas Berger e57b76ef59 docs(08-01): update STATE.md — Task 2 complete, awaiting Task 3 human-verify checkpoint
runner-probe / runner-probe (push) Has been cancelled
2026-06-11 09:53:40 -04:00
Lucas Berger b333d7b7ea feat(08-01): add runner-probe workflow
- Probe-only workflow triggering on gsd/phase-08-gitea-ci branch only
- Answers P-01..P-11 + P-13: Node version, pnpm, runner mode (critical
  fork Docker vs host), Docker socket, MariaDB service container spawn
  and reachability on both hostnames, actions/cache, Playwright WebKit
  deps, gitea-upload-artifact fork, and GITHUB_SHA short-SHA expression
- Uses healthcheck.sh --connect --innodb_initialized for MariaDB (never
  the binary removed from mariadb:11 — Pitfall 11)
- Uses ChristopherHX/gitea-upload-artifact@v4 (not the official action
  which aborts on Gitea with GHES detection — Pitfall 6 / T-08-SC)
- P-12 (docker login) deferred to Plan 04 — probe never references any
  secret (T-08-01 compliant)
- All steps that may fail use continue-on-error: true so probe reports
  findings instead of red-failing on expected unknowns
2026-06-11 09:53:13 -04:00
Lucas Berger 4a510f1d79 docs: add backlog item 999.15 — desktop e2e coverage; drop from phase 8 context 2026-06-11 09:36:53 -04:00
Lucas Berger 41b0b60291 docs(08): create phase plan 2026-06-11 09:34:48 -04:00
Lucas Berger 4e474cdd9c docs(08): create phase plan — 4 plans (runner-probe, PR jobs, harness, publish) 2026-06-11 09:26:48 -04:00
Lucas Berger 92acf02989 docs(08): add validation strategy 2026-06-11 09:16:30 -04:00
Lucas Berger e8a9ce4ea9 docs(state): record phase 8 context session 2026-06-11 08:50:02 -04:00
Lucas Berger c3cee0baae docs(08): capture phase context 2026-06-11 08:50:02 -04:00
Lucas Berger 4303a1b680 docs(07): code-review --fix complete — 5 warnings fixed, re-review status clean 2026-06-11 08:00:55 -04:00
Lucas Berger 9c38dd33ff fix(07): WR-02 explicit readiness flag + WR-01 /api/me dev-bypass gate in global-setup 2026-06-11 07:51:51 -04:00
Lucas Berger 5322cfc2b0 fix(07): WR-06 correct misleading 'remove by reload' comments to describe evaluate(remove) 2026-06-11 07:51:45 -04:00
Lucas Berger 2b745adb29 fix(07): WR-05 drop redundant unroute calls (per-test context isolation handles cleanup) 2026-06-11 07:51:41 -04:00
Lucas Berger c564fc67a1 fix(07): WR-07 prove SW block via getRegistration, skip when SW unavailable 2026-06-11 07:51:34 -04:00