fix(02): correct DURATION-only event end in expand.ts (BUG 1)

- Replace dtend ?? dtstart with event.endDate which handles DURATION-only VEVENTs
- Add positive-duration guard (PT30M / P1D) to both non-recurring and recurring branches
- Add single-duration.ics fixture and regression test asserting end > start for DURATION-only events
This commit is contained in:
Lucas Berger
2026-06-05 14:33:00 -04:00
parent bef4a83fe0
commit ee2281fe81
3 changed files with 89 additions and 3 deletions
+36
View File
@@ -140,6 +140,42 @@ describe('expandOccurrences', () => {
})
})
describe('Non-recurring DURATION-only event — single-duration.ics', () => {
it('BUG-1 regression: non-recurring event with DURATION but no DTEND has end strictly after start', () => {
// Real Fastmail events use DURATION (not DTEND). Before the fix, the NON-RECURRING branch
// used getFirstPropertyValue('dtend') ?? dtstart, which returned dtstart when DTEND was absent,
// producing zero-duration occurrences (invisible in week/day views).
const rawVevent = loadFixture('single-duration.ics')
const windowStart = new Date('2026-06-01T00:00:00Z')
const windowEnd = new Date('2026-07-01T00:00:00Z')
const occurrences = expandOccurrences(
rawVevent,
windowStart,
windowEnd,
1,
'My Calendar',
1,
'#4A90D9',
false,
)
expect(occurrences.length).toBe(1)
const occ = occurrences[0]
expect(occ.allDay).toBe(false)
// Parse both via Temporal.ZonedDateTime and assert end > start
const startZdt = Temporal.ZonedDateTime.from(occ.start)
const endZdt = Temporal.ZonedDateTime.from(occ.end)
expect(Temporal.ZonedDateTime.compare(endZdt, startZdt)).toBeGreaterThan(0)
// Verify the actual duration is correct: DURATION:PT1H → end is 1 hour after start
expect(endZdt.hour - startZdt.hour).toBe(1)
expect(endZdt.minute).toBe(startZdt.minute)
})
})
describe('Cross-contract: expand output → Temporal.ZonedDateTime.from (regression guard)', () => {
it('timed event start/end strings from weekly-dst.ics parse via Temporal.ZonedDateTime.from without throwing', () => {
// This is the integration test that was missing. It takes the actual serializeTime output
+28
View File
@@ -0,0 +1,28 @@
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//FamilySync//Test//EN
BEGIN:VTIMEZONE
TZID:America/Toronto
BEGIN:STANDARD
DTSTART:19701101T020000
RRULE:FREQ=YEARLY;BYDAY=1SU;BYMONTH=11
TZOFFSETFROM:-0400
TZOFFSETTO:-0500
TZNAME:EST
END:STANDARD
BEGIN:DAYLIGHT
DTSTART:19700308T020000
RRULE:FREQ=YEARLY;BYDAY=2SU;BYMONTH=3
TZOFFSETFROM:-0500
TZOFFSETTO:-0400
TZNAME:EDT
END:DAYLIGHT
END:VTIMEZONE
BEGIN:VEVENT
UID:single-duration-only@familysync.test
DTSTART;TZID=America/Toronto:20260618T080000
DURATION:PT1H
SUMMARY:Morning Standup
DESCRIPTION:Non-recurring timed event with DURATION only, no DTEND
END:VEVENT
END:VCALENDAR