luckberg/familysync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(11): sequence plan 11-02 behind 11-01, cite D-09; record planning completion

Browse Source
This commit is contained in:
Lucas Berger
2026-06-13 21:26:16 -04:00
parent 6109d4ca49
commit e169b138f9
3 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.planning/phases/11-per-event-reminders/11-02-PLAN.md
+4 -4
View File
@@ -2,8 +2,8 @@
phase: 11-per-event-reminders
plan: 02
type: tdd
wave: 1
depends_on: []
wave: 2
depends_on: [11-01]
files_modified:
- apps/api/src/broker/reminderScheduler.ts
- apps/api/tests/broker/reminderScheduler.test.ts
@@ -16,7 +16,7 @@ must_haves:
- "A timed event with reminderLeadMinutes=0 produces no push; an all-day event with 0 fires at 9 AM on the event date"
- "Reminders fire on personal calendars too (the isShared-only restriction is dropped)"
- "The same event fires exactly once across consecutive ticks; a rescheduled event (new dtstart) re-fires — dedup key is uid:dtstartMs"
- "Push body is humanized to the largest sensible unit (30 min / 1 hour / 1 day / 7 days)"
- "Push body is humanized to the largest sensible unit (30 min / 1 hour / 1 day / 7 days) (D-09)"
artifacts:
- path: "apps/api/src/broker/reminderScheduler.ts"
provides: "humanizeLeadMinutes, variable-lead query, uid:dtstartMs dedup, all-day 9 AM branch, NULL-vs-0 guard, dropped isShared restriction"
@@ -66,7 +66,7 @@ NOTE: `computeAlertInstantUtc` is created by Plan 11-01 in vevent.ts and importe
</artifacts_this_phase_produces>
<context_note>
This plan imports `computeAlertInstantUtc` from `../broker/vevent.js` (created in Plan 11-01). Until Plan 11-01 merges, the all-day-9AM test (Wave 0 gap) cannot pass — this plan is wave 1 alongside 11-01 but the all-day task's automated verify depends on 11-01's symbol. Sequence the all-day task LAST within this plan; if 11-01 has not yet landed in the shared tree, the executor imports the symbol signature as specified in 11-01's artifacts list and the test goes RED until both merge. Do not redefine computeAlertInstantUtc here.
This plan imports `computeAlertInstantUtc` from `../broker/vevent.js` (created in Plan 11-01). This plan is **wave 2, `depends_on: [11-01]`** — 11-01 lands before this plan runs, so the symbol is available and the all-day-9AM test can go GREEN within this plan. Sequence the all-day task LAST within this plan. Do not redefine computeAlertInstantUtc here — import it from 11-01.
</context_note>
<tasks>