luckberg/familysync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(11-05): WR-03 gate helper text on active preset set only

Browse Source 
- helper text condition now uses (allDay ? ALLDAY_REMINDER_PRESETS : TIMED_REMINDER_PRESETS)
- previously checked !TIMED && !ALLDAY: a timed event with 10080 (in ALLDAY set) was
  incorrectly treated as 'in presets' and suppressed the helper text
- synthetic option gating for each allDay/timed branch was already correct
This commit is contained in:
Lucas Berger
2026-06-14 08:24:24 -04:00
parent 401591374a
commit a04c76b823
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/pwa/src/components/EventForm.tsx
+5 -2
View File
@@ -1029,11 +1029,14 @@ export function EventForm() {
)} )}
</select> </select>
{/* Helper text: shown in edit mode when value is __custom__ or synthetic off-list (D-07) */} {/* Helper text: shown in edit mode when value is __custom__ or synthetic off-list (D-07) */}
{/* WR-03: gate on the ACTIVE preset set only — not both — so a timed event with a
value that happens to be in the allDay set still shows the off-list helper text */}
{eventFormMode === 'edit' && {eventFormMode === 'edit' &&
(reminderValue === '__custom__' || (reminderValue === '__custom__' ||
(reminderValue !== '__none__' && (reminderValue !== '__none__' &&
!TIMED_REMINDER_PRESETS.has(parseInt(reminderValue, 10)) && !(allDay ? ALLDAY_REMINDER_PRESETS : TIMED_REMINDER_PRESETS).has(
!ALLDAY_REMINDER_PRESETS.has(parseInt(reminderValue, 10)) && parseInt(reminderValue, 10),
) &&
Number.isFinite(parseInt(reminderValue, 10)))) && ( Number.isFinite(parseInt(reminderValue, 10)))) && (
<div <div
style={{ style={{