diff --git a/.planning/STATE.md b/.planning/STATE.md index f8274bf..9a3ebe4 100644 --- a/.planning/STATE.md +++ b/.planning/STATE.md @@ -28,7 +28,7 @@ See: .planning/PROJECT.md (updated 2026-06-10) Phase: 999.1 Plan: Not started Status: Phase complete — ready for verification -Last activity: 2026-06-13 +Last activity: 2026-06-13 - Completed quick task 260613-dmw: exclude .gitea/** from CI heavy-job paths-filter ### Deferred Checkpoint — Phase 15 Plan 15-03 Task 2 (human-action) @@ -223,6 +223,7 @@ Recent decisions affecting current work: | 260610-ka9 | Fix silent Android push (Phase 5 UAT Test 4) — SW showNotification had only {body,tag,data} → Android Chromium/Edge showed them silently. Added icon/badge/renotify:true/vibrate; generalized re-enable instructions to Chrome-or-Edge. iOS unaffected. Build emits sw.js with renotify; 187 pwa tests pass | 2026-06-10 | c864fc4 | Verified | [260610-ka9-fix-silent-android-push-notifications-en](./quick/260610-ka9-fix-silent-android-push-notifications-en/) | | 260611-ozt | Split publish job into standalone .gitea/workflows/publish.yml (on: push→main only, no redundant event-guard if:; MILESTONE env moved with it) and strip it + the push trigger from ci.yml — kills the orphaned `CI / publish (pull_request)` pending status (phase-8 code-review WR-01). name:CI + fast-checks/api/harness job ids held stable so the required branch-protection contexts stay valid. Documented the release model in README "Publishing / Releases" + publish.yml header. Both YAML validated (yq) | 2026-06-11 | 92353e1 | | [260611-ozt-split-publish-job-into-standalone-gitea-](./quick/260611-ozt-split-publish-job-into-standalone-gitea-/) | | 260611-tfc | Fix WR-01 (13-REVIEW): apps/pwa/src/sw.ts notificationclick openWindow fallback was unreachable when client.focus() rejects (window closed between matchAll/focus) or client.navigate() resolves null — chained a navigate-result check + a .catch, both falling through to self.clients.openWindow(url). lint/format:check/typecheck green, build emits sw.js, 191/191 pwa tests | 2026-06-12 | af78ccc | Verified | [260611-tfc-fix-wr-01-sw-ts-notificationclick-openwi](./quick/260611-tfc-fix-wr-01-sw-ts-notificationclick-openwi/) | +| 260613-dmw | Exclude `.gitea/**` from the CI `changes` `code` paths-filter so workflow-only PRs skip the heavy api/harness jobs (treated like docs) while fast-checks + gate still run. Single `- '!.gitea/**'` negation appended after the yml/yaml globs (index 11 vs 5). Rides along on the Phase 16 branch / PR #15. | 2026-06-13 | 2d329a9 | | [260613-dmw-exclude-gitea-workflow-config-changes-fr](./quick/260613-dmw-exclude-gitea-workflow-config-changes-fr/) | ## Deferred Items diff --git a/.planning/quick/260613-dmw-exclude-gitea-workflow-config-changes-fr/260613-dmw-PLAN.md b/.planning/quick/260613-dmw-exclude-gitea-workflow-config-changes-fr/260613-dmw-PLAN.md new file mode 100644 index 0000000..14253c5 --- /dev/null +++ b/.planning/quick/260613-dmw-exclude-gitea-workflow-config-changes-fr/260613-dmw-PLAN.md @@ -0,0 +1,90 @@ +--- +phase: quick-260613-dmw +plan: 01 +type: execute +wave: 1 +depends_on: [] +files_modified: [.gitea/workflows/ci.yml] +autonomous: true +requirements: [] + +must_haves: + truths: + - "A PR touching ONLY files under .gitea/** resolves code=false (heavy api/harness jobs skip, gate treats them as OK)" + - "A PR touching .gitea/** AND app code/lockfile still resolves code=true (heavy jobs run)" + - "ci.yml remains valid YAML and passes pnpm format:check" + artifacts: + - path: ".gitea/workflows/ci.yml" + provides: "changes-job paths-filter with .gitea/** excluded from the code filter" + contains: "!.gitea/**" + key_links: + - from: ".gitea/workflows/ci.yml changes.code filter" + to: "api/harness job if: needs.changes.outputs.code == 'true'" + via: "negation pattern ordered after positive yml/yaml globs" + pattern: "!\\.gitea/\\*\\*" +--- + + +Exclude workflow-config changes (`.gitea/**`) from the CI `code` paths-filter so a PR that touches ONLY workflow/CI files is treated like a docs-only PR: the heavy `api` and `harness` jobs skip, while `fast-checks` (always runs; its `format:check` validates the workflow YAML) and `gate` still gate the PR. + +Purpose: Workflow-only edits should not pay the multi-minute MariaDB + integration + Playwright harness cost. Per the project's tiered-gate rule, a CI-config edit does not need the full test harness — `fast-checks` + `gate` are sufficient gates for it. + +Output: A one-line addition to the `changes` job's `dorny/paths-filter@v4` `code` filter in `.gitea/workflows/ci.yml`. + + + +@$HOME/.claude/gsd-core/workflows/execute-plan.md +@$HOME/.claude/gsd-core/templates/summary.md + + + +@.planning/STATE.md +@.gitea/workflows/ci.yml + + + + + + Task 1: Exclude .gitea/** from the CI code paths-filter + .gitea/workflows/ci.yml + +In the `changes` job's `dorny/paths-filter@v4` step (`id: filter`), add a single negation entry `- '!.gitea/**'` to the `code` filter list. Place it as the LAST entry of the `code` list — after every positive glob (`**/*.yaml`, `**/*.yml`, `apps/**`, `packages/**`, `pnpm-lock.yaml`, `Dockerfile`, `docker-compose*.yml`). Ordering is load-bearing: dorny/paths-filter evaluates patterns in sequence and a negation only overrides positive globs that precede it; the `**/*.yml`/`**/*.yaml` globs that currently make `.gitea/` workflow edits resolve `code=true` MUST appear before the negation. + +Match the existing two-space list indentation and single-quoted-glob style used by the surrounding entries. Do NOT remove or reorder any existing positive glob. Do NOT touch the `fast-checks`, `api`, `harness`, `security`, or `gate` jobs, the `outputs.code` mapping, or which jobs `gate` aggregates in its `needs`. This negation is the only change to the file. + +Net behavior after the edit: +- PR touching ONLY `.gitea/**` (e.g. editing this workflow): the yml/yaml positive match is overridden by the negation → `code=false` → `api`/`harness` carry their `if: ... code == 'true'` and skip → `gate`'s success-or-skipped loop accepts them. +- PR touching `.gitea/**` AND app code or lockfile (e.g. `apps/**`, `pnpm-lock.yaml`): the app-code positive glob still matches and is not under `.gitea/`, so the negation does not cancel it → `code=true` → heavy jobs run. + + + cd /home/luc/Projects/familysync && awk '/^ fast-checks:/{exit} /code:/{f=1} f' .gitea/workflows/ci.yml | grep -nE "'!\.gitea/\*\*'|'\*\*/\*\.ya?ml'" && python3 -c 'import sys,yaml; d=yaml.safe_load(open(".gitea/workflows/ci.yml")); code=d["jobs"]["changes"]["steps"][0]["with"]["filters"]; lines=[l.strip().lstrip("- ").strip("\x27\"") for l in code.splitlines() if l.strip().startswith("- ")]; neg=lines.index("!.gitea/**"); yml=max(i for i,p in enumerate(lines) if p in ("**/*.yml","**/*.yaml")); assert neg>yml, f"negation at {neg} must follow last yml/yaml glob at {yml}"; print("OK: .gitea/** negation present and ordered after yml/yaml globs")' + + +`.gitea/workflows/ci.yml` parses as valid YAML; the `code` filter contains `!.gitea/**` positioned after the `**/*.yml`/`**/*.yaml` globs; no positive glob removed; only the `changes` job changed; `pnpm format:check` passes for the file. + + + + + + +1. YAML validity: `python3 -c 'import yaml; yaml.safe_load(open(".gitea/workflows/ci.yml"))'` exits 0. +2. Negation present and correctly ordered: the `code` list contains `!.gitea/**` as an entry that appears AFTER both `**/*.yml` and `**/*.yaml` (asserted by the Task 1 automated check). +3. Formatting: `pnpm format:check` passes (no Prettier diff on the workflow file). +4. Scope guard: `git diff --stat` shows ONLY `.gitea/workflows/ci.yml` changed, and `git diff .gitea/workflows/ci.yml` shows a single added line `- '!.gitea/**'` (no deletions, no other-job edits). + + + +- A workflow-only PR (touching only `.gitea/**`) resolves `code=false` → `api` + `harness` skip → `gate` passes via its success-or-skipped acceptance. +- A PR touching `.gitea/**` plus app code/lockfile resolves `code=true` → heavy jobs run. +- `fast-checks` and `gate` are unchanged and still gate every PR; `fast-checks` `format:check` continues to validate workflow YAML. +- No existing positive glob removed; no change to `fast-checks`, `api`, `harness`, `security`, or `gate`. + + + +Create `.planning/quick/260613-dmw-exclude-gitea-workflow-config-changes-fr/260613-dmw-SUMMARY.md` when done. + +Suggested commit message: +`ci: exclude .gitea/** from heavy-job paths-filter` + +Body rationale: Workflow-only edits shouldn't pay for the multi-minute MariaDB/integration/harness suite. A negation `- '!.gitea/**'` (ordered after the yml/yaml globs) makes CI-config-only PRs resolve code=false so api/harness skip like docs; fast-checks (format:check still validates the workflow YAML) + gate continue to gate them. PRs that also touch app code/lockfile still resolve code=true and run the full suite. + diff --git a/.planning/quick/260613-dmw-exclude-gitea-workflow-config-changes-fr/260613-dmw-SUMMARY.md b/.planning/quick/260613-dmw-exclude-gitea-workflow-config-changes-fr/260613-dmw-SUMMARY.md new file mode 100644 index 0000000..aa69f5d --- /dev/null +++ b/.planning/quick/260613-dmw-exclude-gitea-workflow-config-changes-fr/260613-dmw-SUMMARY.md @@ -0,0 +1,65 @@ +--- +phase: quick-260613-dmw +plan: "01" +subsystem: ci +tags: [ci, paths-filter, workflow] +dependency_graph: + requires: [] + provides: [ci-gitea-exclusion] + affects: [.gitea/workflows/ci.yml] +tech_stack: + added: [] + patterns: [dorny/paths-filter negation glob] +key_files: + created: [] + modified: + - .gitea/workflows/ci.yml +decisions: + - "Negation placed as last entry of the code filter so it overrides all preceding yml/yaml positive globs" +metrics: + duration: "< 5 minutes" + completed: "2026-06-13" + tasks_completed: 1 + tasks_total: 1 + files_modified: 1 +--- + +# Phase quick-260613-dmw Plan 01: Exclude .gitea/** from CI code paths-filter Summary + +**One-liner:** Added `- '!.gitea/**'` as the final entry of the `dorny/paths-filter@v4` `code` filter so workflow-only PRs skip the MariaDB/integration/Playwright harness while fast-checks and gate still gate them. + +## Tasks Completed + +| Task | Name | Commit | Files | +|------|------|--------|-------| +| 1 | Exclude .gitea/** from the CI code paths-filter | 2d329a9 | `.gitea/workflows/ci.yml` | + +## What Was Done + +Single line added to the `changes` job's paths-filter `code` block in `.gitea/workflows/ci.yml`: + +```yaml + - '!.gitea/**' +``` + +Placed after all positive globs (last entry), so: +- A PR touching **only** `.gitea/**` resolves `code=false` → `api` and `harness` skip → `gate` accepts via its success-or-skipped loop. +- A PR touching `.gitea/**` **plus** app code or lockfile resolves `code=true` → heavy jobs run as before. +- `fast-checks` (runs `format:check`, which validates the YAML) and `gate` are unchanged and always gate every PR. +- `security` (gitleaks) is unchanged and always runs. + +## Verification Results + +- YAML validity: `python3 -c 'import yaml; yaml.safe_load(...)'` → exit 0 +- Negation ordering: `!.gitea/**` at index 11, last yml/yaml glob at index 5 → assertion passed +- Scope guard: `git diff --stat` shows exactly 1 file, 1 insertion, 0 deletions +- Formatting: `pnpm format:check` → "All matched files use Prettier code style!" + +## Deviations from Plan + +None — plan executed exactly as written. + +## Self-Check: PASSED + +- `.gitea/workflows/ci.yml` exists and contains `!.gitea/**` +- Commit `2d329a9` present in git log