luckberg/familysync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

style(13-03): apply Prettier formatting across repo

Browse Source 
Mechanical reformat — no logic changes. 398 files changed, 19125
insertions(+), 16457 deletions(-). Prettier 3.8.4 with .prettierrc
(singleQuote:true, semi:true, tabWidth:2, trailingComma:all,
printWidth:100). Isolated per D-13-08 for reviewability.
This commit is contained in:
Lucas Berger
2026-06-11 20:35:18 -04:00
parent 4bc0445173
commit 982438dc10
398 changed files with 19050 additions and 16382 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.planning/phases/08-gitea-ci/08-DISCUSSION-LOG.md
+22 -22
View File
@@ -11,11 +11,11 @@
## Dev-stack bring-up in CI
| Option | Description | Selected |
|--------|-------------|----------|
| Bare processes + service MariaDB | MariaDB as a Gitea service container; API as background `pnpm dev:api` with DEV_AUTH_BYPASS; Playwright webServer starts Vite. No docker-in-docker. | ✓ |
| docker compose dev override | Run docker-compose.yml + dev override inside the runner; adds image-build time + docker-in-docker. | |
| Production image for harness | Build prod image, run harness against API-served PWA on :3000; diverges from Phase 7 dev-server contract. | |
| Option | Description | Selected |
| -------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------- | -------- |
| Bare processes + service MariaDB | MariaDB as a Gitea service container; API as background `pnpm dev:api` with DEV_AUTH_BYPASS; Playwright webServer starts Vite. No docker-in-docker. | ✓ |
| docker compose dev override | Run docker-compose.yml + dev override inside the runner; adds image-build time + docker-in-docker. | |
| Production image for harness | Build prod image, run harness against API-served PWA on :3000; diverges from Phase 7 dev-server contract. | |
**User's choice:** Bare processes + service MariaDB
**Notes:** Reuses the MariaDB service container already needed by the API-integration tests; matches the Phase 7 harness contract exactly.
@@ -24,11 +24,11 @@
## Workflow topology & jobs
| Option | Description | Selected |
|--------|-------------|----------|
| One file, parallel jobs | Single workflow; PR→main runs fast-checks in parallel with integration + harness; push→main publishes. | ✓ |
| Two files | Separate ci.yml + publish.yml; cleaner split, duplicated setup. | |
| One file, linear job | Single sequential job; simplest, slowest feedback. | |
| Option | Description | Selected |
| ----------------------- | ------------------------------------------------------------------------------------------------------ | -------- |
| One file, parallel jobs | Single workflow; PR→main runs fast-checks in parallel with integration + harness; push→main publishes. | ✓ |
| Two files | Separate ci.yml + publish.yml; cleaner split, duplicated setup. | |
| One file, linear job | Single sequential job; simplest, slowest feedback. | |
**User's choice:** One file, parallel jobs
**Notes:** Fast feedback prioritized; minor setup duplication across jobs accepted.
@@ -37,13 +37,13 @@
## Docker image tag strategy
| Option | Description | Selected |
|--------|-------------|----------|
| latest + short SHA | :latest + :<short-sha> | |
| Short SHA only | Immutable per-commit only | |
| latest only | Single moving tag | |
| semver from package.json | Version field + latest | |
| **latest + milestone short (custom)** | :latest + :<milestone>-<shortsha>, e.g. v1.1-4303a1b | ✓ |
| Option | Description | Selected |
| ------------------------------------- | ---------------------------------------------------- | -------- |
| latest + short SHA | :latest + :<short-sha> | |
| Short SHA only | Immutable per-commit only | |
| latest only | Single moving tag | |
| semver from package.json | Version field + latest | |
| **latest + milestone short (custom)** | :latest + :<milestone>-<shortsha>, e.g. v1.1-4303a1b | ✓ |
**User's choice:** latest + `v1.1-4303a1b` (milestone prefix + short SHA), confirmed in follow-up over a 3-tag variant and a no-milestone variant.
**Notes:** Milestone string read from PROJECT.md/ROADMAP, not hardcoded; SHA tag immutable for rollback.
@@ -52,11 +52,11 @@
## Failure artifacts & browser matrix
| Option | Description | Selected |
|--------|-------------|----------|
| Upload on failure + both profiles | iPhone/WebKit + Pixel/Chromium; upload traces/screenshots/videos on failure. | ✓ |
| Upload on failure + Chromium only | Pixel/Chromium only; faster, loses iOS-engine coverage. | |
| Both profiles, no artifacts | Full matrix, log-only failures. | |
| Option | Description | Selected |
| --------------------------------- | ---------------------------------------------------------------------------- | -------- |
| Upload on failure + both profiles | iPhone/WebKit + Pixel/Chromium; upload traces/screenshots/videos on failure. | ✓ |
| Upload on failure + Chromium only | Pixel/Chromium only; faster, loses iOS-engine coverage. | |
| Both profiles, no artifacts | Full matrix, log-only failures. | |
**User's choice:** Upload on failure + both profiles
**Notes:** Full mobile coverage + debuggable failures. `reporter: 'github'` may not render in Gitea — verify in runner probe, fall back if needed.