style(13-03): apply Prettier formatting across repo
Mechanical reformat — no logic changes. 398 files changed, 19125 insertions(+), 16457 deletions(-). Prettier 3.8.4 with .prettierrc (singleQuote:true, semi:true, tabWidth:2, trailingComma:all, printWidth:100). Isolated per D-13-08 for reviewability.
This commit is contained in:
@@ -40,6 +40,7 @@ This is the iteration-2 re-review after the fixer applied 5 changes (commits `c5
|
||||
BL-01, and BL-02; those resolution records are preserved below.
|
||||
|
||||
**Verification performed this pass:**
|
||||
|
||||
- Ran the full suite against the live dev stack (MariaDB :3306, API :3000 `DEV_AUTH_BYPASS=true`,
|
||||
Vite auto-started by `webServer`): **58 passed (55s)**.
|
||||
- Typecheck (`tsc --noEmit` + `tsc --project tsconfig.e2e.json --noEmit`): **exit 0**.
|
||||
@@ -50,7 +51,7 @@ BL-01, and BL-02; those resolution records are preserved below.
|
||||
|
||||
**Result:** all 7 prior warnings are resolved by the fixes (5 actionable + WR-03/WR-04 by-design),
|
||||
no fix introduced a regression or new defect, and no new cross-file issue was exposed.
|
||||
Setting `status: clean`. The 5 IN-* items remain advisory/by-design and are listed under
|
||||
Setting `status: clean`. The 5 IN-\* items remain advisory/by-design and are listed under
|
||||
"Resolved / By-design"; none are actionable.
|
||||
|
||||
---
|
||||
@@ -64,6 +65,7 @@ Setting `status: clean`. The 5 IN-* items remain advisory/by-design and are list
|
||||
|
||||
`globalSetup` TRUNCATEs `list_items`, `list_shares`, `lists`, `calendar_events` against whatever
|
||||
`DB_*` points at. The fix throws **before** opening any DB connection:
|
||||
|
||||
1. `NODE_ENV === 'production'` → throw (checked first).
|
||||
2. `DEV_AUTH_BYPASS !== 'true'` → throw.
|
||||
|
||||
@@ -108,6 +110,7 @@ flags false) matches the API's non-recurring-timed WHERE branch. Verified live o
|
||||
|
||||
The gate now probes `fetch(${baseURL}/api/me, { redirect: 'manual' })` after the `/health` poll
|
||||
and throws unless `res.ok`. Verified correct end-to-end:
|
||||
|
||||
- **Dev-bypass-reachable API → 200.** `me.ts:30-42` short-circuits on `c.get('user')` (DEV_USER)
|
||||
with no DB round-trip, so the gate passes regardless of seed state and regardless of ordering
|
||||
(the probe runs before the seed — confirmed safe because `/api/me` has no DB dependency under
|
||||
@@ -138,6 +141,7 @@ be misreported as a timeout) and any false-positive-ready (the flag is only set
|
||||
|
||||
The trailing `page.unroute(...)` calls were removed and replaced with comments explaining that
|
||||
per-test context isolation handles cleanup. Verified this is correct, not a leak risk:
|
||||
|
||||
- Every `page.route(...)` is registered **inside an individual test body**, never in a shared
|
||||
`beforeEach`/`beforeAll`. Playwright assigns each test a fresh `page`/`BrowserContext`, and route
|
||||
handlers are scoped to that page/context — they cannot leak into sibling tests.
|
||||
@@ -206,7 +210,7 @@ These were never code defects; they are design notes carried for traceability. N
|
||||
- **IN-03 (advisory):** vitest `exclude:['e2e/**']` and Playwright `testDir:'./e2e'` cleanly
|
||||
partition the two runners. Sound.
|
||||
- **IN-04 (advisory):** `typecheck` covers both tsconfigs (re-verified exit 0 this pass). Good.
|
||||
- **IN-05 (advisory):** the CR-01 guard protects *production*, not "the wrong dev DB" — pointing
|
||||
- **IN-05 (advisory):** the CR-01 guard protects _production_, not "the wrong dev DB" — pointing
|
||||
`DB_*` at a populated dev DB with `DEV_AUTH_BYPASS=true` will still TRUNCATE it. By design (D-06
|
||||
deterministic reseed) and documented. A defense-in-depth `E2E_ALLOW_TRUNCATE`/DB-name-pattern
|
||||
opt-in remains an optional hardening, not a defect.
|
||||
@@ -215,15 +219,15 @@ These were never code defects; they are design notes carried for traceability. N
|
||||
|
||||
## Live-run evidence (iteration 2)
|
||||
|
||||
| Check | Result |
|
||||
|---|---|
|
||||
| Full suite (both profiles) | 58 passed (55.0s) |
|
||||
| `iphone` SW-block test | ✓ passed (real assertion ran; not skipped) |
|
||||
| `pixel` SW-block test | ✓ passed |
|
||||
| Seeded-event DB→UI proof (iphone + pixel) | ✓ passed both |
|
||||
| `swAvailable` probe (both engines) | `true` / `getRegistration()=undefined` |
|
||||
| `redirect:'manual'` on a 302 | `ok=false` (gate throws — correct) |
|
||||
| `tsc --noEmit` + e2e tsconfig | exit 0 |
|
||||
| Check | Result |
|
||||
| ----------------------------------------- | ------------------------------------------ |
|
||||
| Full suite (both profiles) | 58 passed (55.0s) |
|
||||
| `iphone` SW-block test | ✓ passed (real assertion ran; not skipped) |
|
||||
| `pixel` SW-block test | ✓ passed |
|
||||
| Seeded-event DB→UI proof (iphone + pixel) | ✓ passed both |
|
||||
| `swAvailable` probe (both engines) | `true` / `getRegistration()=undefined` |
|
||||
| `redirect:'manual'` on a 302 | `ok=false` (gate throws — correct) |
|
||||
| `tsc --noEmit` + e2e tsconfig | exit 0 |
|
||||
|
||||
---
|
||||
|
||||
|
||||
Reference in New Issue
Block a user