docs(07): mark deep-review blockers BL-01/BL-02 resolved (53c3ca5); verification addendum

2026-06-11 07:39:58 -04:00
parent 53c3ca56b8
commit 789e87a360
2 changed files with 37 additions and 3 deletions
@@ -105,9 +105,28 @@ These are carried from the code review as advisory only; none block the phase go

 ### Gaps Summary

-No gaps. All four success criteria are verified against the actual codebase and confirmed by live execution.
+No gaps against the four success criteria — all verified against the actual codebase and confirmed by live execution.
+
+---
+
+## Post-verification addendum (deep code review, 2026-06-11)
+
+A deep cross-file code review run *after* this verification found that two `calendar.spec.ts`
+"populated state" assertions were **vacuous** — they targeted `CalendarShell`'s `EmptyState`
+(dead code, never rendered) and the always-rendered Schedule-X wrapper, so they could not have
+failed if the seed regressed. This did **not** invalidate the four success criteria (SC-1's
+layout/tap-target coverage is `layout.spec.ts`, which carries its own injected-defect
+self-validation and remains sound), but it was a real coverage gap in the calendar
+populated-state tests.
+
+Resolved in commit `53c3ca5`: replaced with a genuine DB→UI proof (`getByText('Seeded Test
+Event')` visible in the grid), verified non-vacuous (passes with the seed on both profiles; with
+`/api/events` mocked to `[]` the title is absent, so the assertion would fail), and re-anchored
+the seed to noon-today so it sits deterministically inside the rendered current-month view. Full
+58-test suite passes on both profiles. See `07-REVIEW.md` BL-01/BL-02.

 ---

 _Verified: 2026-06-11T02:30:00Z_
 _Verifier: Claude (gsd-verifier)_
+_Addendum: 2026-06-11 — deep review BL-01/BL-02 resolved (commit 53c3ca5)_