luckberg/familysync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(08-fix): WR-03 fail closed on empty GITHUB_SHA when computing image tags

Browse Source
This commit is contained in:
Lucas Berger
2026-06-11 19:26:53 -04:00
parent 44a9c307e2
commit 6bcf867e6c
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.gitea/workflows/publish.yml
+6
View File
@@ -41,6 +41,12 @@ jobs:
- name: Compute image tags - name: Compute image tags
id: tags id: tags
run: | run: |
set -euo pipefail
# Fail closed if GITHUB_SHA is empty/unset (Gitea runner env parity is not
# guaranteed across versions). Without this guard SHORT_SHA degrades to ""
# and the immutable tag silently becomes :v1.1- — a valid-but-wrong tag that
# overwrites the milestone pointer and destroys rollback traceability (WR-03).
: "${GITHUB_SHA:?GITHUB_SHA is empty — refusing to build a malformed image tag}"
SHORT_SHA=${GITHUB_SHA:0:7} SHORT_SHA=${GITHUB_SHA:0:7}
MILESTONE="${{ env.MILESTONE }}" MILESTONE="${{ env.MILESTONE }}"
echo "latest=git.bergerhouse.net/luckberg/familysync-api:latest" >> $GITHUB_OUTPUT echo "latest=git.bergerhouse.net/luckberg/familysync-api:latest" >> $GITHUB_OUTPUT