From 4d4ffad0595958550f3dbbc665857abcd17a013c Mon Sep 17 00:00:00 2001 From: Lucas Berger Date: Sat, 13 Jun 2026 11:22:05 -0400 Subject: [PATCH] docs(quick-260613-fp9): .gitea/.planning pushes should not trigger a docker image publish --- .planning/STATE.md | 3 +- .../260613-fp9-PLAN.md | 62 +++++++++++++++++++ .../260613-fp9-SUMMARY.md | 61 ++++++++++++++++++ 3 files changed, 125 insertions(+), 1 deletion(-) create mode 100644 .planning/quick/260613-fp9-gitea-and-planning-pushes-should-not-tri/260613-fp9-PLAN.md create mode 100644 .planning/quick/260613-fp9-gitea-and-planning-pushes-should-not-tri/260613-fp9-SUMMARY.md diff --git a/.planning/STATE.md b/.planning/STATE.md index ca44274..cb4bcfa 100644 --- a/.planning/STATE.md +++ b/.planning/STATE.md @@ -28,7 +28,7 @@ See: .planning/PROJECT.md (updated 2026-06-10) Phase: 999.1 Plan: Not started Status: Phase complete — ready for verification -Last activity: 2026-06-13 - Completed quick task 260613-dmw: exclude .gitea/** from CI heavy-job paths-filter +Last activity: 2026-06-13 - Completed quick task 260613-fp9: .gitea/.planning-only pushes skip the Docker publish ### ✅ Resolved Checkpoint — Phase 15 Plan 15-03 Task 2 (human-action) @@ -215,6 +215,7 @@ Recent decisions affecting current work: | 260611-ozt | Split publish job into standalone .gitea/workflows/publish.yml (on: push→main only, no redundant event-guard if:; MILESTONE env moved with it) and strip it + the push trigger from ci.yml — kills the orphaned `CI / publish (pull_request)` pending status (phase-8 code-review WR-01). name:CI + fast-checks/api/harness job ids held stable so the required branch-protection contexts stay valid. Documented the release model in README "Publishing / Releases" + publish.yml header. Both YAML validated (yq) | 2026-06-11 | 92353e1 | | [260611-ozt-split-publish-job-into-standalone-gitea-](./quick/260611-ozt-split-publish-job-into-standalone-gitea-/) | | 260611-tfc | Fix WR-01 (13-REVIEW): apps/pwa/src/sw.ts notificationclick openWindow fallback was unreachable when client.focus() rejects (window closed between matchAll/focus) or client.navigate() resolves null — chained a navigate-result check + a .catch, both falling through to self.clients.openWindow(url). lint/format:check/typecheck green, build emits sw.js, 191/191 pwa tests | 2026-06-12 | af78ccc | Verified | [260611-tfc-fix-wr-01-sw-ts-notificationclick-openwi](./quick/260611-tfc-fix-wr-01-sw-ts-notificationclick-openwi/) | | 260613-dmw | Exclude `.gitea/**` from the CI `changes` `code` paths-filter so workflow-only PRs skip the heavy api/harness jobs (treated like docs) while fast-checks + gate still run. Single `- '!.gitea/**'` negation appended after the yml/yaml globs (index 11 vs 5). Rides along on the Phase 16 branch / PR #15. | 2026-06-13 | 2d329a9 | | [260613-dmw-exclude-gitea-workflow-config-changes-fr](./quick/260613-dmw-exclude-gitea-workflow-config-changes-fr/) | +| 260613-fp9 | `.gitea`/`.planning`-only pushes to main no longer trigger the Docker publish — added `paths-ignore: ['.gitea/**', '.planning/**']` under `on.push` in `.gitea/workflows/publish.yml` (skips only when EVERY changed file matches; mixed code+docs pushes still publish). `.dockerignore` already excludes `.planning` so the image is byte-identical. Done in isolated worktree (phase-10 agent held main tree). | 2026-06-13 | cd5a88c | | [260613-fp9-gitea-and-planning-pushes-should-not-tri](./quick/260613-fp9-gitea-and-planning-pushes-should-not-tri/) | ## Deferred Items diff --git a/.planning/quick/260613-fp9-gitea-and-planning-pushes-should-not-tri/260613-fp9-PLAN.md b/.planning/quick/260613-fp9-gitea-and-planning-pushes-should-not-tri/260613-fp9-PLAN.md new file mode 100644 index 0000000..80630f2 --- /dev/null +++ b/.planning/quick/260613-fp9-gitea-and-planning-pushes-should-not-tri/260613-fp9-PLAN.md @@ -0,0 +1,62 @@ +--- +quick_id: 260613-fp9 +title: ".gitea and .planning pushes should not trigger a docker image publish" +status: ready +--- + +# Quick Task 260613-fp9: Skip Docker publish for `.gitea`/`.planning`-only pushes + +## Problem + +`.gitea/workflows/publish.yml` triggers on every `push` to `main` with no path +filter. Two classes of push currently fire a full Docker build + publish that +produce an identical image: + +- `.planning/**`-only commits, which push straight to `main` (the `.planning/*` + branch-protection pattern is unprotected). +- `.gitea/**`-only changes (CI/workflow edits) merged via PR. + +Neither changes the shipped artifact — `.dockerignore` already excludes +`.planning` (and `apps/api/tests`) from the image — so the rebuild is wasted +runner time and a needless `:latest` re-push / new `:vMILESTONE-` tag. + +## Change + +Add a `paths-ignore` filter to the `push` trigger in `publish.yml`: + +```yaml +on: + push: + branches: [main] + paths-ignore: + - '.gitea/**' + - '.planning/**' +``` + +Gitea Actions follows GitHub-compatible workflow syntax (the repo already relies +on the native `branches:` push filter). When every file changed in a push to +`main` matches a `paths-ignore` glob, the `publish` job is skipped. A push that +also touches code/Dockerfile/manifests still triggers publish — correct. + +Also update the header comment block to document the new skip behavior. + +## Tasks + +1. **Edit `.gitea/workflows/publish.yml`** + - files: `.gitea/workflows/publish.yml` + - action: Add `paths-ignore: ['.gitea/**', '.planning/**']` under `on.push`; + update the top-of-file `# Trigger:` comment to note doc/CI-only pushes skip. + - verify: `paths-ignore` present under `on.push`; YAML still parses; the + existing `--target production` self-assertion grep still matches. + - done: pushes touching only `.gitea/**` and/or `.planning/**` no longer + trigger the publish job; mixed pushes (code + docs) still publish. + +## must_haves + +- truths: + - publish.yml `on.push` carries a `paths-ignore` listing `.gitea/**` and `.planning/**` + - `branches: [main]` is retained +- artifacts: + - `.gitea/workflows/publish.yml` +- key_links: + - `.gitea/workflows/publish.yml` diff --git a/.planning/quick/260613-fp9-gitea-and-planning-pushes-should-not-tri/260613-fp9-SUMMARY.md b/.planning/quick/260613-fp9-gitea-and-planning-pushes-should-not-tri/260613-fp9-SUMMARY.md new file mode 100644 index 0000000..574eaff --- /dev/null +++ b/.planning/quick/260613-fp9-gitea-and-planning-pushes-should-not-tri/260613-fp9-SUMMARY.md @@ -0,0 +1,61 @@ +--- +quick_id: 260613-fp9 +title: ".gitea and .planning pushes should not trigger a docker image publish" +status: complete +date: 2026-06-13 +--- + +# Quick Task 260613-fp9 — Summary + +## What changed + +Added a `paths-ignore` filter to the `push` trigger in +`.gitea/workflows/publish.yml`: + +```yaml +on: + push: + branches: [main] + paths-ignore: + - '.gitea/**' + - '.planning/**' +``` + +Updated the file's header comment to document the new skip behavior. + +## Why + +Every push to `main` previously ran a full Docker build + push. Pushes confined +to `.planning/**` (planning docs push straight to main under the unprotected +`.planning/*` branch-protection pattern) or `.gitea/**` (CI/workflow edits) never +change the shipped image — `.dockerignore` already excludes `.planning`. The +rebuild and `:latest` re-push were wasted runner time. + +## Behavior + +- Push touching only `.gitea/**` and/or `.planning/**` → `publish` job skipped. +- Push touching code / Dockerfile / manifests (alone or mixed with docs) → + `publish` runs as before. `paths-ignore` skips only when **every** changed + file matches a glob. + +## Verification + +- `python3 yaml.safe_load` parses the file; `on.push` carries both + `branches: [main]` and `paths-ignore: ['.gitea/**', '.planning/**']`; the + `publish` job is intact. +- The in-workflow `grep "--target production"` self-assertion still matches + (D-10 hygiene check unaffected). + +## Isolation note + +Executed in a dedicated worktree (`familysync-wt-fp9`, branch +`quick/260613-fp9-publish-paths-ignore` off `origin/main`) because a concurrent +phase-10 agent has the main working tree checked out on +`gsd/phase-10-admin-role-settings`. No subagents spawned — trivial single-file +config edit done inline. + +## Follow-up + +`publish.yml` lives under `.gitea/**`, so merging this change will itself be a +`.gitea`-only push and will (correctly) not publish. Open a PR to `main` +(protected; code changes require PR).