luckberg/familysync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(07): WR-05 drop redundant unroute calls (per-test context isolation handles cleanup)

Browse Source
This commit is contained in:
Lucas Berger
2026-06-11 07:51:41 -04:00
parent c564fc67a1
commit 2b745adb29
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/pwa/e2e/lists.spec.ts
+4 -5
View File
@@ -87,9 +87,9 @@ test.describe('Rule 5 — lists empty state (network-simulated, seeded DB untouc
// Body contains "Tap + to create your first shared list" — use partial match // Body contains "Tap + to create your first shared list" — use partial match
await expect(page.getByText(/Tap \+ to create/)).toBeVisible() await expect(page.getByText(/Tap \+ to create/)).toBeVisible()
// No manual unroute (WR-05): Playwright gives each test a fresh page/context, so route
// Unroute so the mock does not leak to subsequent tests (T-07-11) // handlers do not leak across tests; a trailing unroute also never runs if an `expect`
await page.unroute('/api/lists') // above throws.
}) })
test('no horizontal overflow in empty lists state (Rule 2)', async ({ page }) => { test('no horizontal overflow in empty lists state (Rule 2)', async ({ page }) => {
@@ -115,7 +115,6 @@ test.describe('Rule 5 — lists empty state (network-simulated, seeded DB untouc
overflow.scrollWidth, overflow.scrollWidth,
`scrollWidth (${overflow.scrollWidth}) must be ≤ clientWidth (${overflow.clientWidth}) in empty lists state`, `scrollWidth (${overflow.scrollWidth}) must be ≤ clientWidth (${overflow.clientWidth}) in empty lists state`,
).toBeLessThanOrEqual(overflow.clientWidth) ).toBeLessThanOrEqual(overflow.clientWidth)
// No manual unroute (WR-05): per-test context isolation handles route cleanup.
await page.unroute('/api/lists')
}) })
}) })