luckberg/familysync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(19): resolve post-merge wave-4 harness integration gaps

Browse Source 
Two issues surfaced only when plans 19-04 (login UI) and 19-05 (Option C
bypass + login.spec) were merged together and run against the real stack —
neither executor could catch them in isolation:

1. LOCAL_SESSION_SECRET was added to the CI harness (ci.yml) but not to the
   local dev stack (docker-compose.dev.yml). Without it the real-login success
   path (POST /api/auth/local/login) 503s when signing the session cookie, so
   the e2e round-trip failed. Add the same fixed dev-only value to the dev
   compose override (dev-only target; never a production secret).

2. login.spec test 1 assumed clearing the local-session cookie yields a
   logged-out state, but under the always-on DEV_AUTH_BYPASS devAuthBypass()
   injects DEV_USER into /api/me regardless of any cookie — a logged-out state
   is architecturally unreachable in this bypass-only harness. Reframe the test
   to drive /login directly (validating the real-browser render of all brand +
   form surfaces) and move the unauthenticated root->/login redirect-gate
   coverage to a unit test in App.test.tsx where meQuery.isError is controllable.

Result: API 446/446, PWA 265/265 (+2 gate tests), e2e desktop 42 passed / 3
skipped (all login specs green).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Lucas Berger
2026-06-17 17:43:11 -04:00
co-authored by Claude Opus 4.8
parent 11977fddf4
commit 17a531550a
3 changed files with 73 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docker-compose.dev.yml
+6
View File
@@ -13,6 +13,12 @@ services:
# NODE_ENV !== 'production' (and the production image bakes NODE_ENV=production),
# so this can never activate in a shipped image. Required by the e2e harness.
DEV_AUTH_BYPASS: 'true'
# Phase 19 (AUTH-LOCAL-16, D-14/D-15): required for devSessionCookieMiddleware to
# issue real local-session cookies under bypass AND for the real-login round-trip
# (POST /api/auth/local/login) to sign a session — without it that path 503s.
# Fixed dev-only value, mirrors the CI harness job (.gitea/workflows/ci.yml) —
# NEVER a production secret; this override file is dev-only (target: dev).
LOCAL_SESSION_SECRET: 'dev-secret-change-me-0000000000000000'
mariadb:
ports: