fix(13-02): eliminate all ESLint violations — pnpm lint exits 0
- eslint.config.js: disable React Compiler rules (v7 flat.recommended enables
them; codebase does not use the Compiler); add e2e/ to disableTypeChecked
block; promote exhaustive-deps to error
- API broker: remove redundant as-casts (outboxWorker, poller, reminderScheduler,
expand, sync, vevent, spike); add targeted ical.js no-unsafe-assignment/argument
disables with justifying comments inside try blocks
- API routes/sse.ts: fix no-misused-promises on async writeSSE callback with
void+IIFE+catch pattern
- API routes/lists.ts: let → const for updateValues
- API tests: remove unused imports (beforeEach, eq, vi); rename unused vars
with _ prefix; remove unused lastActiveId assignment
- PWA components: void navigate() and void queryClient.invalidateQueries() on
all fire-and-forget call sites; fix CalendarShell explicit-type-casts;
Couldn't → HTML entity
- PWA test files: as unknown as Response for partial mock objects; string | null
type annotation on mockLastSyncedUid; remove async from test callbacks without
await; act(() => {}) not await act(async () => {}) for sync ops
- sw.ts: restructure Notification.data?.url access as let+if so disable
comments land on the exact violation lines; void self.skipWaiting()
This commit is contained in:
@@ -518,7 +518,7 @@ describe('GET /api/events/sync-status', () => {
|
||||
const mockOrderBy = vi.fn().mockImplementation(() => Promise.resolve(mockDbRows))
|
||||
const mockLimit = vi.fn().mockReturnValue(mockOrderBy)
|
||||
const mockSimpleWhere = vi.fn().mockReturnValue({ limit: mockLimit })
|
||||
const mockOrderByDirect = vi.fn().mockImplementation(() => Promise.resolve(mockDbRows))
|
||||
const _mockOrderByDirect = vi.fn().mockImplementation(() => Promise.resolve(mockDbRows))
|
||||
// Some implementations use .where().orderBy() or just .where()
|
||||
mockSimpleWhere.mockReturnValue({ limit: mockLimit, orderBy: vi.fn().mockReturnValue({ limit: vi.fn().mockResolvedValue(mockDbRows) }) })
|
||||
mockFromFn.mockReturnValue({ where: mockSimpleWhere })
|
||||
|
||||
@@ -510,7 +510,6 @@ async function seedItem(
|
||||
rank: string,
|
||||
checked = false,
|
||||
): Promise<number> {
|
||||
const { eq } = await import('drizzle-orm')
|
||||
const [result] = await db.insert(listItems).values({ listId, text, rank, checked }).$returningId()
|
||||
return result.id
|
||||
}
|
||||
@@ -646,7 +645,7 @@ describe('PATCH /api/list-items/:id — per-field LWW (D-08)', () => {
|
||||
const listId = await seedList(ownerId, 'Uncheck Rank', false)
|
||||
// Two active items
|
||||
await seedItem(listId, 'alpha', 'a0')
|
||||
const lastActiveId = await seedItem(listId, 'beta', 'a1')
|
||||
await seedItem(listId, 'beta', 'a1')
|
||||
// One checked item (to uncheck)
|
||||
const checkedItemId = await seedItem(listId, 'checked-one', 'Zz', true)
|
||||
|
||||
@@ -1055,8 +1054,8 @@ describe('PATCH /api/list-items/:id { position } — reorder ordering (LIST-03,
|
||||
const ownerId = await seedUser('reorder-lww')
|
||||
currentDevUserId = ownerId
|
||||
const listId = await seedList(ownerId, 'Reorder LWW', false)
|
||||
const id1 = await seedItem(listId, 'alpha', 'a0')
|
||||
const id2 = await seedItem(listId, 'beta', 'a1')
|
||||
const _id1 = await seedItem(listId, 'alpha', 'a0')
|
||||
const _id2 = await seedItem(listId, 'beta', 'a1')
|
||||
const id3 = await seedItem(listId, 'gamma', 'a2')
|
||||
|
||||
const app = await getApp()
|
||||
|
||||
Reference in New Issue
Block a user